refactor(#2255): multi instance - move expand actions to nodes #3234
+164
−176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move expansion logic from actions/tree/modifiers/expand.lua into DirectoryNode and Explorer methods. Update API to use new methods via wrap_explorer. Remove expand module and its setup calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the expand functionality by moving it from the actions layer into node methods, improving encapsulation and making the code more object-oriented.
Changes
lua/nvim-tree/actions/tree/modifiers/expand.luamoduleDirectoryNodeandExplorerclasses as methodsDirectoryNode:expand()- public method for recursive directory expansionDirectoryNode:expand_dir_node()- helper to open and load a single directoryNode:expand()- dispatcher that handles both file and directory nodesExplorer:expand_all()andExplorer:expand_node()- wrapper methods for the APIExplorermethods viawrap_explorercore.get_explorer()calls withself.explorerreferencesExplorer:expand()toExplorer:expand_dir_node()to avoid naming conflictsmodifiers.setup()as it's no longer neededBenefits
Related Issues
Closes #2255