fix(#3187): prevent closing the last non-floating window when deleting files

[Fidelxyz]

Fixes #3187

[Copilot]

Pull request overview

This PR fixes a bug where nvim-tree would throw an E444: Cannot close last window error when deleting a file that's currently open, in configurations where multiple floating windows exist (such as from the Snacks plugin). The previous logic counted total windows, which failed when floating windows were present. The fix correctly counts only non-floating windows to determine when it's safe to close windows.

Changes:

• Updated window closing logic to count non-floating windows instead of total windows
• Prevents closing the last non-floating window when nvim-tree is in floating mode

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[alex-courtis]

Please do not add AI reviews:

https://github.com/nvim-tree/nvim-tree.lua?tab=contributing-ov-file#pull-request

https://github.com/nvim-tree/nvim-tree.lua?tab=contributing-ov-file#ai-usage-policy-highly-discouraged

[Fidelxyz]

Ouch, sorry I did't realized I enabled AI reviews... Turing it off.

[alex-courtis]

Many thanks for dealing with this one; that horrible < 3 has been hanging around for too long.

Code looks safe and clear.

Test ok:

• issue test case
  • float enabled
  • float disabled
  • actions config commented
• default config