Skip to content

Conversation

@sghng
Copy link
Contributor

@sghng sghng commented Dec 20, 2025

The symbol is the same as regular XML. To distinguish it from regular XML, I picked a blue-ish color adopted from VSCode-icons, which also uses orange for xml and blue for xslt.

Copilot AI review requested due to automatic review settings December 20, 2025 20:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds icon support for .xslt (Extensible Stylesheet Language Transformations) file extensions. The implementation uses the same XML icon symbol but with a blue color scheme to distinguish XSLT files from regular XML files.

  • Adds .xslt file extension entry to the icons table
  • Uses blue color (#33A9DC) inspired by VSCode-icons, distinguishing it from orange XML files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alex-courtis
Copy link
Member

Oh dear... an unwanted review from copilot. Have you seen one of these before @gegoune ?

It looks like it might have been enabled by default in the repo settings for devicons and nvim-tree...

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To distinguish it from regular XML, I picked a blue-ish color adopted from VSCode-icons, which also uses orange for xml and blue for xslt.

Nice one! Many thanks for your contribution.

@alex-courtis alex-courtis changed the title feat: icon for .xslt files feat: add .xslt icon Dec 21, 2025
@alex-courtis alex-courtis merged commit 6788013 into nvim-tree:master Dec 21, 2025
6 checks passed
@sghng sghng deleted the feat/xslt branch December 21, 2025 03:33
@gegoune
Copy link
Collaborator

gegoune commented Dec 21, 2025

Oh dear... an unwanted review from copilot. Have you seen one of these before @gegoune ?

It looks like it might have been enabled by default in the repo settings for devicons and nvim-tree...

Yes, seems that way. thought you might have added it. Shall we try to disable it?

@alex-courtis
Copy link
Member

Oh dear... an unwanted review from copilot. Have you seen one of these before @gegoune ?
It looks like it might have been enabled by default in the repo settings for devicons and nvim-tree...

Yes, seems that way. thought you might have added it. Shall we try to disable it?

Definitely not me ;) Let's try and kill it.

@sghng
Copy link
Contributor Author

sghng commented Dec 22, 2025

I realized that it might be my setting... Just turned it off

image

@alex-courtis
Copy link
Member

I realized that it might be my setting... Just turned it off

Interesting. I've created a not-for-merge PR to test this: #617

@alex-courtis
Copy link
Member

No copilot review was created for #617 closing it.

Attempting to turn off any copilot settings.

I realized that it might be my setting... Just turned it off

Please don't be concerned @sghng , there are a lot of changes happening on github and none of us are sure what is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants