Skip to content

Conversation

@afma-odoo
Copy link
Contributor

task-4499493

@robodoo
Copy link
Collaborator

robodoo commented Dec 15, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team December 15, 2025 10:39
@afma-odoo
Copy link
Contributor Author

Hi Ismail and @ygu-odoo ,
Thank you for your work on this Saudi-Arabia localization page!
I made some changes/suggestions. Please take a look at it and let me know if you have any questions or comments. Thanks!

  • Modules: All Saudi Arabia modules have been added.
  • Structure: I reviewed the document to simplify the structure and align it with our new guidelines and templates for LOC documentation pages. Some sections were moved and added as notes/important alert blocks.
  • Sandbox and simulation (line 272 & 273): It would be helpful to include more information about when to use one or the other. Could you provide it? 
  • Simulation & Production (313): I split this section into two to be as precise and complete as possible: one for simulation modeand one for production mode.
  • Re-onboard vs Onboard (298, 331 & 362): When I tested it (for the first time), the available option was "onboard". Is this okay?
  • Invoice testing step (306 & 339), I added a step because a blue banner appears when I test it. Is this okay? Is this option also available in production mode?
  • Invoice testing step (306 & 339), I added some information to make the instructions as precise as possible. Let me know if it's incorrect.
  • QR code verification (453): I think we should add some more information about this note. What do you think?

Thank you for your help! ☺️

@afma-odoo
Copy link
Contributor Author

@elis-odoo Thank you for your comments/suggestions. I updated the page accordingly.
If there's anything else, I'd be happy to update the document, or just let me know if I can proceed and r+ the PR.
Thank you!

@afma-odoo afma-odoo force-pushed the 19.0-localization-saudi-arabia-afma branch from 00daa6d to 72147d1 Compare January 6, 2026 10:18
Copy link

@ygu-odoo ygu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, final run and some minor changes

@afma-odoo afma-odoo force-pushed the 19.0-localization-saudi-arabia-afma branch from 72147d1 to 17358c2 Compare January 7, 2026 09:55
@afma-odoo
Copy link
Contributor Author

Hi @ygu-odoo and @elis-odoo,
Thank you for your comments ;) I updated the document. Don't hesitate to let me know if there's anything else I can improve.
For the Retention section, I had to group some admonition blocks together to make the text easier to read and avoid having too many different blocks in the same section. Let me know what you think about it.
Thank you!
.

Copy link

@ygu-odoo ygu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, two minor changes and we are good to go!

@afma-odoo afma-odoo force-pushed the 19.0-localization-saudi-arabia-afma branch from 17358c2 to f637f35 Compare January 7, 2026 11:18
@auva-odoo
Copy link
Contributor

@robodoo delegate+

@afma-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants