Skip to content

Conversation

@hokolomopo
Copy link
Contributor

Description

This commit adds a data-type attribute to each tab in the figure carousel, so we can create css selector based on the carousel item type.

Task: 5447027

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

This commit adds a `data-type` attribute to each tab in the figure
carousel, so we can create css selector based on the carousel item type.

Task: 5447027
@robodoo
Copy link
Collaborator

robodoo commented Jan 6, 2026

Pull request status dashboard

Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants