Skip to content

Conversation

@Rohit0301
Copy link
Contributor

@Rohit0301 Rohit0301 commented Dec 31, 2025

Describe your changes:

Fixes

I worked on ... because ...

Screenshot 2026-01-04 at 2 47 30 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Form label standardization:
    • Replaced Typography with FormLabel in MUISwitch and Tags form components for consistent asterisk rendering
    • Created StyledFormLabel wrapper component with theme-aware styling in TagsForm.tsx
  • MUI theme enhancement:
    • Added MuiFormLabel.asterisk style override in form-theme.ts using colors.error[600] token
  • Button styling improvements:
    • Updated Cancel buttons in ClassificationFormDrawer and TagFormDrawer from outlined to text variant
  • Legacy styles updated:
    • Changed hardcoded asterisk color to use @red-14 variable in form.less
  • Test updates:
    • Added ThemeProvider wrapper to drawer component tests for proper MUI theme context

This will update automatically on new commits.


@github-actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.77% (51492/79505) 42.47% (25175/59282) 45.96% (7949/17296)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

@gitar-bot
Copy link

gitar-bot bot commented Jan 2, 2026

🔍 CI failure analysis for f697aa6: Playwright job 59304014164 failed with 1 test failure and 1 flaky test in DataAssetRulesDisabled bulk edit operations. This is the same recurring test stability issue unrelated to the PR's form styling changes.

Issue

Playwright CI job playwright-ci-postgresql (1, 6) failed with test instability in DataAssetRulesDisabled feature.

Root Cause

Recurring test stability issues in DataAssetRulesDisabled bulk edit operations:

  • 1 failed test: Database bulk edit action
  • 1 flaky test: Database Schema bulk edit action
  • 58 tests passed

Details

Failing tests (from DataAssetRulesDisabled.spec.ts):

  1. Database @dataAssetRules - Failed
  2. Database Schema @dataAssetRules - Flaky

Both tests are using fillRowDetails from importUtils.ts:760 and experiencing timeout/stability issues.

Why this is not related to PR changes:

Commit f697aa6 ("address PR comment") modifies:

  • Cancel button styling in ClassificationFormDrawer
  • Form label components and styling
  • MUI theme integration for form elements

None of these changes affect:

  • Bulk edit operations for data assets
  • Import/export utilities (importUtils.ts)
  • Database/schema operations
  • Test execution stability

Pattern recognition:

This is the same test failure pattern observed in previous CI runs:

  • Job 59267510024 (commit dc7cb5a): Same DataAssetRulesDisabled tests failed
  • Job 59267510036 (commit dc7cb5a): Same pattern
  • Job 59304014164 (commit f697aa6): Same tests failing again

The failures are occurring across different commits of this PR, all in the same test file and operations, indicating a test stability issue rather than a code problem introduced by this PR.

Conclusion

This is a persistent test flakiness issue in DataAssetRulesDisabled bulk edit operations that affects multiple CI runs. The solution is to re-run the job or investigate the test stability issues in DataAssetRulesDisabled.spec.ts separately from this PR.

Code Review 👍 Approved with suggestions

Solid UI refactoring for Tags page forms with consistent MUI styling. Previous finding about cancel button lacking disabled state during loading remains unresolved.

Resolved ✅ 1 resolved
Edge Case: Cancel button disabled during loading prevents error recovery

📄 openmetadata-ui/src/main/resources/ui/src/pages/TagsPage/ClassificationFormDrawer.tsx:100 📄 openmetadata-ui/src/main/resources/ui/src/pages/TagsPage/TagFormDrawer.tsx:104
Both ClassificationFormDrawer.tsx and TagFormDrawer.tsx disable the cancel button when isLoading is true. This prevents users from canceling an operation that may be stuck or failed, reducing their ability to recover from error states.

Impact: If a form submission hangs or encounters a network issue, users cannot close the drawer to retry or abandon the operation.

Suggestion: Consider keeping the cancel button enabled during loading, or implement a timeout mechanism that re-enables it after a period. The close (X) button in the drawer header should also remain functional as an escape hatch.

What Works Well

Good use of memoization in MUISelect for the optionsMap. Consistent application of MUIFormItemLabel across components. Test updates properly wrap components with ThemeProvider.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off Gitar will not commit updates to this branch.
✅ Code review is on Gitar will review this change.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

Auto-apply ✅ Code review Compact
gitar auto-apply:on         
gitar code-review:off         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

@Rohit0301 Rohit0301 changed the title fix: FIxed the asterisk color bug for MUI labels fix: Fixed the asterisk color bug for MUI labels Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants