-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: Fixed the asterisk color bug for MUI labels #25012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
openmetadata-ui/src/main/resources/ui/src/styles/components/form.less
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/common/MUISelect/MUISelect.tsx
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/common/MUISelect/MUISelect.tsx
Outdated
Show resolved
Hide resolved
|
🔍 CI failure analysis for f697aa6: Playwright job 59304014164 failed with 1 test failure and 1 flaky test in DataAssetRulesDisabled bulk edit operations. This is the same recurring test stability issue unrelated to the PR's form styling changes.IssuePlaywright CI job Root CauseRecurring test stability issues in DataAssetRulesDisabled bulk edit operations:
DetailsFailing tests (from
Both tests are using Why this is not related to PR changes: Commit f697aa6 ("address PR comment") modifies:
None of these changes affect:
Pattern recognition: This is the same test failure pattern observed in previous CI runs:
The failures are occurring across different commits of this PR, all in the same test file and operations, indicating a test stability issue rather than a code problem introduced by this PR. ConclusionThis is a persistent test flakiness issue in DataAssetRulesDisabled bulk edit operations that affects multiple CI runs. The solution is to re-run the job or investigate the test stability issues in Code Review 👍 Approved with suggestionsSolid UI refactoring for Tags page forms with consistent MUI styling. Previous finding about cancel button lacking disabled state during loading remains unresolved. Resolved ✅ 1 resolvedEdge Case: Cancel button disabled during loading prevents error recovery
What Works WellGood use of memoization in MUISelect for the optionsMap. Consistent application of MUIFormItemLabel across components. Test updates properly wrap components with ThemeProvider. Tip Comment OptionsAuto-apply is off Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs) |



Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
TypographywithFormLabelinMUISwitchand Tags form components for consistent asterisk renderingStyledFormLabelwrapper component with theme-aware styling inTagsForm.tsxMuiFormLabel.asteriskstyle override inform-theme.tsusingcolors.error[600]tokenClassificationFormDrawerandTagFormDrawerfrom outlined to text variant@red-14variable inform.lessThemeProviderwrapper to drawer component tests for proper MUI theme contextThis will update automatically on new commits.