Skip to content

Conversation

@harsh-vador
Copy link
Contributor

@harsh-vador harsh-vador commented Jan 1, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Legacy component removal:
    • Deleted DataAssetSummaryPanel directory (328 lines) consolidating to DataAssetSummaryPanelV1 only
  • LESS to MUI migration:
    • Migrated 6 components to MUI Box with sx prop: DescriptionSection, CommonEntitySummaryInfoV1, DataProductsSection, OwnersSection, GlossaryTermsSection, TagsSection
    • Deleted 6 LESS files: DescriptionSection.less, OverviewSection.less, DataProductsSection.less, OwnersSection.less, GlossaryTermsSection.less, TagsSection.less (~774 lines total)
  • Type safety improvements:
    • Replaced any types with MergedEntityData and Type interfaces in EntitySummaryPanel.component.tsx
  • Test updates:
    • Updated Playwright and unit tests to use data-testid selectors instead of CSS class selectors for better test resilience

This will update automatically on new commits.


@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.79% (51455/79413) 42.55% (25202/59232) 45.98% (7948/17287)

@harsh-vador harsh-vador removed the cleanup Code clean up task label Jan 2, 2026
@gitar-bot
Copy link

gitar-bot bot commented Jan 5, 2026

Code Review 👍 Approved with suggestions

Well-executed migration from LESS stylesheets to MUI's sx prop styling system with comprehensive test updates. Two minor typo/quality issues found.

Suggestions 💡 2 suggestions
Bug: Typo in sx prop: "paddding" instead of "padding"

📄 openmetadata-ui/src/main/resources/ui/src/components/common/DataProductsSection/DataProductsSection.tsx:1252

In DataProductsSection.tsx, there's a typo in the sx prop where "paddding" is used instead of "padding". This will cause the padding style to be silently ignored.

sx={{
  ...
  paddding: '3px 0',  // Should be "padding"
  ...
}}

This won't cause a runtime error but the padding won't be applied as expected.

Suggested fix: Change paddding to padding.

Code Quality: Missing theme dependency in tagsContent useMemo

📄 openmetadata-ui/src/main/resources/ui/src/components/common/TagsSection/TagsSection.tsx:290

In DataProductsSection.tsx, the dataProductsContent useMemo hook uses dataProductsDisplay which now depends on theme, but the dependencies array doesn't include all transitive dependencies.

Looking at line 1336, the dependency array for tagsContent includes tagsDisplay which now uses theme, but this change propagates correctly through the memoization chain since tagsDisplay is in the dependency array.

Similarly, in DataProductsSection.tsx, the dataProductsContent memo at around line 347-352 properly depends on the dataProductsDisplay which is updated.

However, it would be cleaner to include theme directly if the component relies on theme for rendering within those memos, to make the dependencies explicit.

What Works Well

Clean migration pattern consistently applied across all affected components (TagsSection, OwnersSection, GlossaryTermsSection, DescriptionSection, DataProductsSection). Test files properly updated with ThemeProvider wrappers and improved test-id based selectors replacing CSS class queries. Good cleanup of unused DataAssetSummaryPanel component and 6 LESS files.

Options

Auto-apply is off Gitar will not commit updates to this branch.
✅ Code review is on Gitar will review this change.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

Auto-apply ✅ Code review Compact
gitar auto-apply:on         
gitar code-review:off         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants