Sync instrument stress test #7986
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
Jan 16, 2026
| AggregationTemporality aggregationTemporality, | ||
| InstrumentType instrumentType, | ||
| MemoryMode memoryMode, | ||
| InstrumentValueType instrumentValueType) { |
Member
Author
There was a problem hiding this comment.
Parameterized testing really shines here.
jack-berg
commented
Jan 16, 2026
| Uninterruptibles.joinUninterruptibly(collectThread); | ||
|
|
||
| // Assert collected data is consistent with recorded measurements by independently computing the | ||
| // expected aggregated value and comparing to the actual results. |
Member
Author
There was a problem hiding this comment.
This is the key bit. We independently compute the expected aggregated state outside the concurrent record environment, and compare against the SDK, treating it as a black box.
jack-berg
commented
Jan 16, 2026
sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/SynchronousInstrumentStressTest.java
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7986 +/- ##
============================================
- Coverage 90.16% 90.16% -0.01%
+ Complexity 7478 7473 -5
============================================
Files 836 833 -3
Lines 22550 22524 -26
Branches 2224 2235 +11
============================================
- Hits 20333 20308 -25
+ Misses 1515 1512 -3
- Partials 702 704 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
commented
Jan 16, 2026
...telemetry/sdk/metrics/internal/aggregator/DoubleBase2ExponentialHistogramAggregatorTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing some work to improve the performance of metric recording under high contention, and touching sensitive code in
DefaultSynchronousMetricStorageand other concurrent code.I have promising results, but the first step is buffing up our stress tests for synchronous instruments.
A stress test for synchronous instruments concurrently runs record and collect operations at a high rate, and tries to find instances of concurrency bugs: lost writes, duplicate writes, partial writes, etc.
We need to test every combination of of the following dimensions, since each plays a key role in the recording and collecting code flows.
That's 40 combinations. Our current test suite is hand rolled for some of these cases, but misses many.