Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Feb 8, 2026

Motivated by #8060 (well, that and the many PRs in the instrumentation repo where this has plagued me recently)

Context:

When compiling with --release 8, javac's -Xlint:deprecation warns on imports of deprecated classes (JDK-8032211). Since @SuppressWarnings cannot suppress import-level warnings, this forced us to use fully-qualified class names as a workaround.

}

@SuppressWarnings("unchecked")
@SuppressWarnings({"unchecked", "deprecation"}) // deprecation: EXTENDED_ATTRIBUTES
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's slightly more strict than javac here, but this does align with Intellij's warnings, so seems good

@trask trask force-pushed the deprecate-with-errorprone branch 4 times, most recently from 4dd1d41 to e79ae1d Compare February 8, 2026 05:13
@trask trask force-pushed the deprecate-with-errorprone branch from e79ae1d to cfd48d7 Compare February 8, 2026 05:18
@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.25%. Comparing base (6893380) to head (cfd48d7).

Files with missing lines Patch % Lines
...ntelemetry/sdk/testing/logs/TestLogRecordData.java 0.00% 3 Missing ⚠️
...sting/logs/internal/TestExtendedLogRecordData.java 0.00% 3 Missing ⚠️
...entelemetry/sdk/logs/ExtendedSdkLogRecordData.java 0.00% 1 Missing ⚠️
...va/io/opentelemetry/sdk/logs/SdkLogRecordData.java 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (76.47%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8061      +/-   ##
============================================
+ Coverage     90.23%   90.25%   +0.02%     
+ Complexity     7602     7600       -2     
============================================
  Files           838      838              
  Lines         22806    22782      -24     
  Branches       2274     2274              
============================================
- Hits          20578    20561      -17     
+ Misses         1518     1509       -9     
- Partials        710      712       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant