test(mcp): assert runner emits tool_call_output_item on MCP failures#2556
Open
OiPunk wants to merge 1 commit intoopenai:mainfrom
Open
test(mcp): assert runner emits tool_call_output_item on MCP failures#2556OiPunk wants to merge 1 commit intoopenai:mainfrom
OiPunk wants to merge 1 commit intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #2554, adjusted based on maintainer feedback.
Instead of only asserting that the run continues, this test now explicitly verifies that runner-level MCP tool failures are surfaced as a generated
tool_call_output_item.What changed
test_runner_emits_mcp_error_tool_call_output_itemintests/mcp/test_runner_calls_mcp.py.tool_call_output_itemis produceddefault_tool_error_functionfinal_output == "done")Validation
Locally run:
env -u all_proxy -u ALL_PROXY -u http_proxy -u HTTP_PROXY -u https_proxy -u HTTPS_PROXY -u no_proxy -u NO_PROXY uv run --with pytest pytest -q tests/mcp/test_runner_calls_mcp.pyuv run --with ruff ruff check tests/mcp/test_runner_calls_mcp.pyuv run --with mypy mypy tests/mcp/test_runner_calls_mcp.pyAll passed locally.