fix(openapi-typescript): missing jsdocs comment anyof nested schema#2143
fix(openapi-typescript): missing jsdocs comment anyof nested schema#2143alewin wants to merge 1 commit intoopenapi-ts:mainfrom
Conversation
❌ Deploy Preview for openapi-ts failed.
|
|
| if (anyOfDescriptions.length > 0) { | ||
| output.push(`@description ${anyOfDescriptions.join(" | ")}`); | ||
| } | ||
| } |
There was a problem hiding this comment.
It seems like this will still fail for generating jsdoc descriptions for the other compositions allOf and oneOf.
At least in the case of allOf you could re-use this logic and intersect (&) the entries of instead of union-ing (|) them.
There was a problem hiding this comment.
yes, makes sense to me. I’ll try to take AllOf and OneOf into account in this PR then
Changes
proposal fix for #2142
What does this PR change? Link to any related issue(s).
How to Review
How can a reviewer review your changes? What should be kept in mind for this review?
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)