feat(openapi-react-query): add prefixQueryKey option#2357
Open
jeiea wants to merge 1 commit intoopenapi-ts:mainfrom
Open
feat(openapi-react-query): add prefixQueryKey option#2357jeiea wants to merge 1 commit intoopenapi-ts:mainfrom
jeiea wants to merge 1 commit intoopenapi-ts:mainfrom
Conversation
❌ Deploy Preview for openapi-ts failed.
|
🦋 Changeset detectedLatest commit: 1f048dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Awesome that this is on the way, I'm facing the same problem right now in my code and the only good option is to have an easy way of prefixing the queryKeys for a specific client! |
Author
|
@htunnicliff @kerwanp Please give me any kind of comments. What’s your first impression of this PR? Are there any immediate concerns? Would you prefer to explore a different direction? Even if you’re still thinking it through, it’d be great if you could share your thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Close #1979.
Current openapi-react-query has a potential issue because
useQuerycalls from different clients are assigned the same key, even though they're querying different endpoints.For example:
Here, both queries receive the same key, even though they are querying different sources.
This try to resolve the problem.
Changes
prefixQueryKeyparameter to differentiate cache identities.How to Review
unknowntype.See
packages/openapi-react-query/test/index.test.tsx:270, and feel free to leave a comment if you have any other thoughts.Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)