Open
Conversation
Collaborator
|
Thanks for the patch! I've had a look at this and the preparatory cleanup work in patches 1-3 seems good to me. From what I can see of patch 4 it also seems reasonable, however the formatting style e.g. braces around for() loops etc. doesn't seem to match that of the existing code. Can you repush with the formatting corrected? Finally can I ask what you're using this for? I don't really have a way of testing EFI builds here so I'd be reliant on someone else to make sure that this patchset is working as expected. |
reinauer
approved these changes
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a very basic EFI romheaders support. It also prints a short comment on code type 0xff, which is being used by iPXE.