Convert fcode-utils to Linux kernel indentation#8
Open
reinauer wants to merge 4 commits intoopenbios:masterfrom
Open
Convert fcode-utils to Linux kernel indentation#8reinauer wants to merge 4 commits intoopenbios:masterfrom
reinauer wants to merge 4 commits intoopenbios:masterfrom
Conversation
Signed-off-by Stefan Reinauer <stefan.reinauer@coreboot.org>
Drop separate Makefiles and license files. Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
it helps get rid of unneeded casting Signed-of-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
We have version control. Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
ghost
reviewed
Sep 7, 2021
detok/addfcodes.c
Outdated
| for (indx = 0; indx < spcl_func_count; indx++) { | ||
| if ( strcmp( vs_fc_name, spcl_func_list[indx].name) == 0 ) { | ||
| if (strcmp | ||
| (vs_fc_name, |
There was a problem hiding this comment.
Is this (parens on the next line) really Linux style? And even if, is this something to emulate?
ghost
reviewed
Sep 7, 2021
| #if 0 /* Fooey on C's petty limitations! */ | ||
| /* I'd like to be able to do this: */ | ||
| /* Special Functions */ | ||
| #if 0 /* Fooey on C's petty limitations! */ |
There was a problem hiding this comment.
maybe start the comment on the next line so that the indenter knows what to do about it?
ghost
reviewed
Sep 7, 2021
| **************************************************************************** */ | ||
|
|
||
| void link_token( token_t *curr_token) | ||
| void link_token(token_t * curr_token) |
There was a problem hiding this comment.
I think the indenter mixed up multiplication and pointer type here
ghost
reviewed
Sep 7, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
The general thrust is reasonable, but there are some questionable decisions made that need resolution, otherwise we'll flip-flop between various inconsistent styles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by Stefan Reinauer stefan.reinauer@coreboot.org