Frameworks path in local_addons fix#343
Merged
dimitre merged 26 commits intoopenframeworks:masterfrom Apr 15, 2023
Merged
Conversation
Member
Author
|
Hello @ofTheo this one is good to go. |
Member
|
great! feel free to merge when ready!! 🎉🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a hard coded local_addons when adding Frameworks from addons.
Fix a issue where addons were added multiple times when added by dependencies of other addons. The result is the same but it is more performant.
Update some functions to fs::path
dylibs files now goes to its own folder in local_addons too.
And some minor changes.