Skip to content

Conversation

@deleSerna
Copy link

@deleSerna deleSerna commented Dec 31, 2025

Description
Currently, if we miss the @Reflect annotation on methods called from kernel functions, no method is generated for them in the corresponding backend. This causes an error like:

> error: implicit declaration of function 'squareitWithoutReflectAnnotation' is invalid...
Solution

  • Throw error if Reflect annotation is missing on all methods called from the kernel function that are defined in the same class as the kernel function.

Test

  • A new test is added at hat.test.TestMissingReflectAnnotation#testTransitiveMethodFromKernelWithoutReflectAnnotation

Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/798/head:pull/798
$ git checkout pull/798

Update a local copy of the PR:
$ git checkout pull/798
$ git pull https://git.openjdk.org/babylon.git pull/798/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 798

View PR using the GUI difftool:
$ git pr show -t 798

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/798.diff

Using Webrev

Link to Webrev Comment

…ing on transitive methods from kernel method
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 31, 2025

👋 Welcome back ntv! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 31, 2025

@deleSerna This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Improved error message if Reflect annotation is missing on transitive methods from kernel method

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 31, 2025
@deleSerna
Copy link
Author

/integrate

@mlbridge
Copy link

mlbridge bot commented Dec 31, 2025

Webrevs

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 31, 2025
@openjdk
Copy link

openjdk bot commented Dec 31, 2025

@deleSerna
Your change (at version 0afd2a0) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 2, 2026
@deleSerna deleSerna changed the title Improved error message on OpenCLBackend if Reflect annotation is missing on transitive methods from kernel method Improved error message if Reflect annotation is missing on transitive methods from kernel method Jan 2, 2026
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 2, 2026
@openjdk
Copy link

openjdk bot commented Jan 8, 2026

@deleSerna this pull request can not be integrated into code-reflection due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout verify_reflect_annotation_part2_retry
git fetch https://git.openjdk.org/babylon.git code-reflection
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge code-reflection"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed ready Pull request is ready to be integrated labels Jan 8, 2026
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

5 participants