-
Notifications
You must be signed in to change notification settings - Fork 36
Improved error message if Reflect annotation is missing on transitive methods from kernel method #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: code-reflection
Are you sure you want to change the base?
Improved error message if Reflect annotation is missing on transitive methods from kernel method #798
Conversation
…ing on transitive methods from kernel method
|
👋 Welcome back ntv! A progress list of the required criteria for merging this PR into |
|
@deleSerna This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
Webrevs
|
|
@deleSerna |
Reviewed-by: mabbay
Reviewed-by: psandoz
|
@deleSerna this pull request can not be integrated into git checkout verify_reflect_annotation_part2_retry
git fetch https://git.openjdk.org/babylon.git code-reflection
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge code-reflection"
git push |
Description
Currently, if we miss the @Reflect annotation on methods called from kernel functions, no method is generated for them in the corresponding backend. This causes an error like:
> error: implicit declaration of function 'squareitWithoutReflectAnnotation' is invalid...Solution
Test
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/798/head:pull/798$ git checkout pull/798Update a local copy of the PR:
$ git checkout pull/798$ git pull https://git.openjdk.org/babylon.git pull/798/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 798View PR using the GUI difftool:
$ git pr show -t 798Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/798.diff
Using Webrev
Link to Webrev Comment