Skip to content

Conversation

@grfrost
Copy link
Collaborator

@grfrost grfrost commented Jan 5, 2026

This one change simplifies a bunch of code.

We frequently had this pattern

var opToReplace = .....;
var  newOp = new MyNewOp(...);
newOp.setLocation(opToReplace.getLocation());
builder.op(newOp);

We were forced to catch the newOp just to set its location.

This change allows

builder.op( new myNewOp(....)
     .setLocation(opToReplace)
);

Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/811/head:pull/811
$ git checkout pull/811

Update a local copy of the PR:
$ git checkout pull/811
$ git pull https://git.openjdk.org/babylon.git pull/811/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 811

View PR using the GUI difftool:
$ git pr show -t 811

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/811.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2026

👋 Welcome back gfrost! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@grfrost This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Make Op.setLocation fluent friendly by returning Op

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2026

Webrevs

Copy link
Member

@PaulSandoz PaulSandoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you update the JavaDoc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants