8374810: [lworld] Generate COH archives

[coleenp]

This change both enables the UseCompactObjectHeaders archives for valhalla and fixes the test that looks for the archives. Testing with tier1-3 with --enable-preview and -XX:+UseCompactObjectHeaders.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8374810: [lworld] Generate COH archives (Enhancement - P4)

Reviewers

• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1871/head:pull/1871
$ git checkout pull/1871

Update a local copy of the PR:
$ git checkout pull/1871
$ git pull https://git.openjdk.org/valhalla.git pull/1871/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1871

View PR using the GUI difftool:
$ git pr show -t 1871

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1871.diff

Using Webrev

Link to Webrev Comment

[coleenp]

/issue add JDK-8366774

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374810: [lworld] Generate COH archives

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the lworld branch:

• 13abe7d: 8374165: [lworld] Shortcut in value copying can lead to incorrect substitutability tests
• 093d033: 8374554: [lworld] Field layout assert with UseCompactObjectHeaders
• d8438ac: 8366717: [lworld] Cleanup defensive fixing of JDK-8365996
• ... and 5 more: https://git.openjdk.org/valhalla/compare/90dfb4391ad964f21d2af23f978931b97e751380...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[openjdk]

@coleenp The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

[mlbridge]

Webrevs

• 00: Full (486bc1f6)

[fparain]

Looks good to me.
But I have a question that could be addressed in a different patch: why is the suffix of the archive still '_valhalla' ? Shouldn't it be '_preview' now that the "Valhalla" mode is controlled by the "--enable-preview" option?

[coleenp]

Thank you Fred. I think we might have to go through and rename the _valhalla in the archive to something else. I'm not sure how many files are affected so I wouldn't do that here. And we should see if everyone agrees on a new name. The _preview suffix might be good.