Closed
Conversation
Contributor
Author
|
I have clang-format v19 locally, but I'm not sure why the formatting check is failing (all changes are very simple changes to header paths) |
Contributor
|
Thanks @aprilnovak for the PR. @jtramm and I have talked for a while about replacing xtensor with something internal for a variety of reasons, and I just learned today that he has been busy behind the scenes working on a replacement that is evidently nearly complete and is close to submitting a PR. So, let's wait for that to come in and hopefully that will resolve the issue with the latest clang compilers! 🤞 |
5 tasks
Contributor
Author
|
Even better! Thanks @jtramm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update OpenMC to xtensor v 0.26. Confirms this works with clang 19.1.7. This is necessary for many Cardinal users who rely on MOOSE's conda environment, which uses clang by default.
Fixes # 3183
Checklist