Add RefreshToken model and database entity
#1791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new IntegrationAuthorization model and corresponding database infrastructure to track user authorizations for external integrations.
Key Changes:
- Added
IntegrationAuthorizationTypeBox schema model with fields for user, project, organization, token, integration name, and revocation status - Created database entity with foreign key relationships and composite index on projectId and integrationName
- Implemented database migration to create the integration_authorization table
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/lib/integration-authorization/integration-authorization.ts | Defines the IntegrationAuthorization TypeBox schema with required fields |
| packages/shared/src/index.ts | Exports the new IntegrationAuthorization model |
| packages/server/api/src/app/integration-authorization/integration-authorization.entity.ts | Creates TypeORM entity schema with relations and composite index |
| packages/server/api/src/app/database/postgres-connection.ts | Registers the migration in the migrations list |
| packages/server/api/src/app/database/migrations/1766579857000-CreateIntegrationAuthorizationTable.ts | Implements database migration to create the table with foreign keys and index |
| packages/server/api/src/app/database/database-connection.ts | Adds IntegrationAuthorizationEntity to the list of registered entities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/server/api/src/app/integration-authorization/integration-authorization.entity.ts
Outdated
Show resolved
Hide resolved
packages/server/api/src/app/integration-authorization/integration-authorization.entity.ts
Outdated
Show resolved
Hide resolved
packages/server/api/src/app/integration-authorization/integration-authorization.entity.ts
Outdated
Show resolved
Hide resolved
packages/server/api/src/app/integration-authorization/integration-authorization.entity.ts
Outdated
Show resolved
Hide resolved
.../server/api/src/app/database/migrations/1766579857000-CreateIntegrationAuthorizationTable.ts
Outdated
Show resolved
Hide resolved
.../server/api/src/app/database/migrations/1766579857000-CreateIntegrationAuthorizationTable.ts
Outdated
Show resolved
Hide resolved
.../server/api/src/app/database/migrations/1766579857000-CreateIntegrationAuthorizationTable.ts
Outdated
Show resolved
Hide resolved
…d database entity.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
rSnapkoOpenOps
changed the title
IntegrationAuthorization model and database entityRefreshToken model and database entity
| "principal" jsonb NOT NULL, | ||
| "is_revoked" boolean NOT NULL DEFAULT false, | ||
| "revoked_at" TIMESTAMP WITH TIME ZONE, | ||
| "expirationTime" TIMESTAMP WITH TIME ZONE, |
Contributor
There was a problem hiding this comment.
Should it be not null?
Collaborator
Author
There was a problem hiding this comment.
No, i think we need to keep an option for tokens without expiration date
Contributor
There was a problem hiding this comment.
Why do we need tokens that don't expire?
packages/server/api/src/app/database/migrations/1766579857000-CreateRefreshTokenTable.ts
Outdated
Show resolved
Hide resolved
| await queryRunner.query(` | ||
| CREATE INDEX IF NOT EXISTS "idx_refresh_token_project_id_and_client" ON "refresh_token" ("projectId", "client") | ||
| `); | ||
|
|
Contributor
There was a problem hiding this comment.
Missing constraints:
- Unique refreshToken
- Unique refreshToken, projectId, userId, client, isRevoked false
packages/server/api/src/app/database/migrations/1766579857000-CreateRefreshTokenTable.ts
Outdated
Show resolved
Hide resolved
packages/server/api/src/app/database/migrations/1766579857000-CreateRefreshTokenTable.ts
Outdated
Show resolved
Hide resolved
packages/server/api/src/app/database/migrations/1766579857000-CreateRefreshTokenTable.ts
Outdated
Show resolved
Hide resolved
packages/server/api/src/app/database/migrations/1766579857000-CreateRefreshTokenTable.ts
Show resolved
Hide resolved
…CreateRefreshTokenTable.ts Co-authored-by: Marcelo Gonçalves <marcelo@openops.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OPS-2994.