-
-
Notifications
You must be signed in to change notification settings - Fork 12
Add comprehensive localization to learningmap web components with language settings #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: mikebarkmin <2592379+mikebarkmin@users.noreply.github.com>
Co-authored-by: mikebarkmin <2592379+mikebarkmin@users.noreply.github.com>
Co-authored-by: mikebarkmin <2592379+mikebarkmin@users.noreply.github.com>
|
@copilot I have updated many things. Do not bother with the initial request. Can you implement localization for the learningmap web-component. I have already set up a language prop. You need to find all strings and create translations for English and German. |
Co-authored-by: mikebarkmin <2592379+mikebarkmin@users.noreply.github.com>
Localization has been implemented! I've added English and German translations for all strings in the learningmap editor component. What was added:
Coverage includes:
The component defaults to English if no language is specified. Commit: |
…:openpatch/hyperbook into copilot/add-learningmap-editor-component
|
@copilot please update the LearningMap component to use the translations. |
Co-authored-by: mikebarkmin <2592379+mikebarkmin@users.noreply.github.com>
Localization has been added to the LearningMap viewer component! All user-facing strings are now translated for English and German. Updated components:
Translated strings include:
The language prop now flows through the entire component tree in both the editor and viewer. Commit: 6e5dd1f |
|
@copilot Update the Settings type to include a language and add a language chooser in the SettingsDrawer. |
Co-authored-by: mikebarkmin <2592379+mikebarkmin@users.noreply.github.com>
Language property and chooser have been added! The Settings type now includes a Changes:
The language setting persists with the roadmap file, so each roadmap can have its own language preference. Commit: 5d8b7e3 |
|
@copilot the learningmap component should also use the settings language if available. |
Co-authored-by: mikebarkmin <2592379+mikebarkmin@users.noreply.github.com>
The LearningMap viewer component now uses the language from settings! It works the same way as the editor: Changes:
Both the editor and viewer now consistently respect the language setting from the roadmap file. Commit: d45a219 |
…:openpatch/hyperbook into copilot/add-learningmap-editor-component
LearningMap Viewer Language Settings
Updated the LearningMap viewer component to use the language from settings if available, matching the behavior of the LearningMapEditor.
Changes Made:
Updated LearningMap.tsx:
settings.languageif available, falls back tolanguagepropeffectiveLanguagevariable to determine which language to useHow It Works:
languagepropThis ensures consistency between the editor and viewer - both now respect the language setting saved in the roadmap data while still supporting the language prop as a fallback. When users save a roadmap with a specific language in the editor, the viewer will automatically display in that language when the roadmap is loaded.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.