Skip to content

hack/cluster-version-util/task_graph: Task-node granularity #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wking wants to merge 2 commits into
base: main
Choose a base branch
from
Open

hack/cluster-version-util/task_graph: Task-node granularity #1221

wking wants to merge 2 commits into from

Conversation

@wking
Copy link
Member

@wking wking commented Aug 6, 2025

Re-opening #991, but against main instead of master, now that the dev branch has been renamed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@wking wking force-pushed the task-node-granularity branch from f61fa93 to 46d4020 Compare August 6, 2025 00:54
wking added 2 commits August 6, 2025 03:39
@wking
hack/cluster-version-util/task_graph: Task-node granularity
7f96433 
Make it easier to think about task-nodes as opaque objects by
assigning them runlevel and component properties, and using that
information to label names in the rendered graph.
@wking
docs/user/tasks-*by-number-and-component.svg: Update to 4.20
e89c7a9 
Using a similar process to cde8d50 (docs/user/reconciliation:
Document release-image application, 2019-06-10, openshift#201) and 4353698
(docs/user/tasks-*by-number-and-component.svg: Update to 4.13,
2023-07-25, openshift#949), but for 4.20.0-ec.5.  The SVGs were generated with
the new --granularity flag set to 'manifest', to make it easier for
cluster operator maintainers to understand how their manifests are
collected into task nodes:

  $ go build ./hack/cluster-version-util
  $ mkdir /tmp/release
  $ oc image extract quay.io/openshift-release-dev/ocp-release:4.20.0-ec.5-x86_64[-1] --path /:/tmp/release
  $ mkdir /tmp/release/manifests
  $ ./cluster-version-util task-graph --granularity manifest /tmp/release | dot -Tsvg >docs/user/tasks-by-number-and-component.svg
  $ ./cluster-version-util task-graph --granularity manifest --parallel flatten-by-number-and-component /tmp/release | dot -Tsvg >docs/user/tasks-flatten-by-number-and-component.svg

using:

  $ go version
  go version go1.23.6 linux/amd64
  $ dot -V
  dot - graphviz version 2.43.0 (0)
@wking wking force-pushed the task-node-granularity branch from 46d4020 to e89c7a9 Compare August 6, 2025 10:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview e89c7a9 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-agnostic-ovn e89c7a9 link true /test e2e-agnostic-ovn
ci/prow/unit e89c7a9 link true /test unit
ci/prow/e2e-agnostic-operator-devpreview e89c7a9 link false /test e2e-agnostic-operator-devpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@petr-muller
Copy link
Member

petr-muller commented Aug 19, 2025

/cc

but fails unit tests

@openshift-ci openshift-ci bot requested a review from petr-muller August 19, 2025 13:31
@petr-muller
Copy link
Member

petr-muller commented Oct 7, 2025

/uncc

@openshift-ci openshift-ci bot removed the request for review from petr-muller October 7, 2025 09:58
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 6, 2026

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wking @petr-muller @openshift-bot