Split file lock tests #771
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request splits the file-lock test suite into two separate test groups (file-lock and file-lock2) to reduce CI execution time through parallelization. The original file-lock tests took ~10m30s, while the split results in file-lock running in ~6m8s and file-lock2 in ~5m30s, achieving the goal of faster test execution.
Key changes:
- Created a new
file-lock2test group by moving 8 test files from the original file-lock suite - Updated build configuration files (Makefile.am, Makefile.in) to define dependencies and targets for file-lock2
- Modified CI workflow files to include file-lock2 in test execution across coverage, pull-request, and push workflows
Reviewed changes
Copilot reviewed 7 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/file-lock2.at | New main test file that includes all 8 moved test cases using m4_include directives |
| tests/file-lock2.src/*.at | Eight test files moved from file-lock to file-lock2 (input-mode, same-process, open-start-write-rewrite, release-lock, open-input, lock-mode-clause, lock-mode-automatic, old-file) |
| tests/file-lock.at | Updated to remove m4_include directives for the 8 tests moved to file-lock2 |
| tests/Makefile.am | Added file-lock2 to TESTS list and defined indexed_lock2_DEPENDENCIES (contains syntax errors) |
| tests/Makefile.in | Added file-lock2 test targets and log configuration (contains syntax errors) |
| .gitignore | Added tests/file-lock2 to ignore generated test artifacts |
| .github/workflows/coverage.yml | Added file-lock2 to the test execution list |
| .github/workflows/pull-request.yml | Added file-lock2 to both standard and UTF-8 test matrices |
| .github/workflows/push.yml | Added file-lock2 to standard test matrix and UTF-8 matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reorganizes and expands the test suite by splitting the existing
file-locktests into two separate test groups:file-lockand a newfile-lock2. The change will reduce CI execution time.Older Version
New Version
Test suite reorganization:
file-lock2by moving several test cases (input-mode.at,same-process.at,open-start-write-rewrite.at,release-lock.at,open-input.at,lock-mode-clause.at,lock-mode-automatic.at,old-file.at) fromfile-locktofile-lock2. Added a new test driver filetests/file-lock2.atto include these tests.tests/Makefile.amandtests/Makefile.into define dependencies and test targets forfile-lock2, ensuring it is built and run as part of the test suite.CI and workflow updates:
.github/workflows/coverage.yml,pull-request.yml,push.yml) to addfile-lock2to the set of tests run in various CI jobs, ensuring coverage for the new test group.