Nodeset rabbitmquser finalizer management and status tracking via configmap #1781
Conversation
When using LOCAL_REGISTRY=1 with operator replace directives pointing to personal forks (e.g., lmiccini/*), the script was trying to query the local registry for bundle images that don't exist there, causing curl to return null and jq to fail with "Cannot iterate over null (null)". Root cause: Bundle images from personal forks are only published to quay.io in the user's namespace (e.g., quay.io/lmiccini/glance-operator-bundle) and are NOT mirrored to the local CI registry. The local registry only contains standard openstack-k8s-operators bundles. The fix: 1. Check IMAGEBASE first (takes precedence for custom registry settings) 2. For replaced operators (GITHUB_USER != "openstack-k8s-operators"): - Always query quay.io with the user's namespace - Skip local registry entirely 3. For standard operators: use local registry when LOCAL_REGISTRY=1 4. Update curl logic to only query local registry for standard operators This allows CI builds with depends-on to work correctly when the dependency uses replace directives for operator APIs. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lmiccini The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@lmiccini: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/56ac80bd0e7547ad88350eb0206886b5 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 18m 47s |
| // Set default cluster if not specified | ||
| if r.Spec.Nova.Template.MessagingBus.Cluster == "" { | ||
| r.Spec.Nova.Template.MessagingBus.Cluster = "rabbitmq" | ||
| } |
There was a problem hiding this comment.
I think this should be handled inside NovaSpecCore only - which is already implemented in nova-operator PR in api/v1beta1/nova_webhook.go.
right now this prevents nova-operator default logic and causing validation errors.
https://privatebin.corp.redhat.com/?c45396e58303c070#DdJdtAVGx7JKct4gDwEUMgXxnndx9GUa3p19dFkoA8ZJ
There was a problem hiding this comment.
I am redepoying with cmd shrared by @lmiccini and this time, and pods in openstack namespace coming up
and no similar errors in openstack-operator-controller-manager pod this time.
There was a problem hiding this comment.
Adding main error in case paste bin expires soon
2026-01-30T06:01:11Z ERROR Metadate update failed
{"controller": "openstackcontrolplane", "controllerGroup": "core.openstack.org", "controllerKind": "OpenStackControlPlane",
"OpenStackControlPlane": {"name":"openstack-galera-network-isolation","namespace":"openstack"},
"namespace": "openstack", "name": "openstack-galera-network-isolation", "reconcileID": "08f45e2e-d6ba-458e-ac9b-d934aceeda48",
"error": "admission webhook \"vopenstackcontrolplane-v1beta1.kb.io\"
denied the request: OpenStackControlPlane.core.openstack.org \"openstack-galera-network-isolation\" is invalid:
spec.nova.template.cellTemplates[cell1].cellMessageBusInstance:
Invalid value: \"rabbitmq-cell1\": cannot set both
deprecated field \"spec.nova.template.cellTemplates[cell1].cellMessageBusInstance\"
and
new field \"spec.nova.template.cellTemplates[cell1].messagingBus.cluster\"
with different values (deprecated: \"rabbitmq-cell1\", new: \"rabbitmq\").
Use \"spec.nova.template.cellTemplates[cell1].messagingBus.cluster\" only"}
There was a problem hiding this comment.
was a leftover from previous attempts, should be gone now.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
No description provided.