[OSPRH-25851] Ignore empty node sets during data plane OVN minor update #1786
+86
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abays
commented
Jan 30, 2026
| "ansibleSSHPrivateKeySecret": "dataplane-ansible-ssh-private-key-secret", | ||
| }, | ||
| "nodes": map[string]interface{}{}, | ||
| "servicesOverride": []string{}, |
Contributor
Author
There was a problem hiding this comment.
I removed this because the servicesOverride field doesn't actually exist in OpenStackDataPlaneNodeSet. It's found in OpenStackDataPlaneDeployment instead, so this line is misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a minor update, we currently mistakenly consider empty
OpenStackDataPlaneNodeSets and wait for their non-existent OVN deployments to update. We should ignore them in this context instead, in order to prevent unnecessarily blocking the update and thus obviate the need for manual intervention to unblock it (which can be done by deleting the emptyOpenStackDataPlaneNodeSets).Tested locally in a CIFMW dev-scripts environment with a minor update of VA1:
OpenStackDataPlaneNodeSetafter initial deploymentJira: https://issues.redhat.com/browse/OSPRH-25851