-
Notifications
You must be signed in to change notification settings - Fork 102
[neutron-ovn] Add nova-metadata secret as optional #1787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
OVN Agent also supports metadata extension, but without nova-metadata config it fails. Added nova-metadata-neutron-config secret to the neutron-ovn dataplane service as optional. Resolves: #OSPRH-25996 Signed-off-by: Yatin Karel <ykarel@redhat.com>
|
/lgtm |
OVN Agent also supports metadata extension, but without nova-metadata config it fails. Add metadata config pattern(from neutron_metadata role) also to ensure the metadata config also get's set. Metadata secret being included as part of [1]. [1] openstack-k8s-operators/openstack-operator#1787 Resolves: #OSPRH-25997 Signed-off-by: Yatin Karel <ykarel@redhat.com>
abays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, danpawlik, karelyatin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@karelyatin: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
OVN Agent also supports metadata extension, but
without nova-metadata config it fails.
Added nova-metadata-neutron-config secret to
the neutron-ovn dataplane service as optional.
Resolves: #OSPRH-25996