fix: remove unused --hotkey option and split inspect into two tables#841
fix: remove unused --hotkey option and split inspect into two tables#841Nicknamess96 wants to merge 2 commits intoopentensor:stagingfrom
Conversation
Remove the regressed --hotkey parameter from wallet inspect command and split the single 9-column table into two focused tables: a Coldkey Overview table and a Hotkey Details table. - Remove wallet_hotkey parameter from wallet_inspect signature - Update help text to reflect coldkey-only wallet display - Refactor inspect output into separate coldkey and hotkey tables - Extract helper functions for delegate/neuron row generation - Add unit tests for all new helper functions - Remove unused itertools import Fixes opentensor#233
ibraheem-abe
left a comment
There was a problem hiding this comment.
Hey @Nicknamess96
- Can you recheck
get_delegatedmethod in subtensor.py and compare with how the upstream returns this result? I think we need to update the data structure - It will be nice if we also provide a ss58_address option to the command, since there are no extrinsics involved, this will allow users to check data for other coldkeys as well
- The hotkey details table has
taosymbol in staked instead of the subnet's alpha symbol.
bittensor_cli/cli.py
Outdated
There was a problem hiding this comment.
Would need to remove this
…ommand - Remove early exit that disabled inspect on rao network - Add --ss58-address option so users can inspect any coldkey without a local wallet file (read-only, no extrinsics) - Fix hotkey details table to show subnet alpha symbols instead of tao symbol by calling Balance.set_unit(netuid) - Refactor inspect() to work with SS58 addresses directly, decoupling data fetching from wallet file existence Verified get_delegated in subtensor_interface.py — the method signature and return type match upstream (main and staging). No data structure update needed.
|
Hey @ibraheem-abe, thanks for the review! Pushed fixes for all points: 1. 2. 3. Alpha symbol fix — Hotkey details table now calls 4. Early exit removed — Removed the Ready for re-review. |
Summary
Address the remaining work from #233 by removing the regressed
--hotkeyparameter from the wallet inspect command and splitting the single combined table into two separate, focused tables as suggested by @thewhaleking.PR #770 previously removed the
--hotkeyoption, but subsequent merges re-introduced the parameter and reverted the help text. This PR re-applies those fixes and additionally splits the inspect output into:Changes
wallet_hotkeyparameter fromwallet_inspectCLI handlerNonefor hotkey inwallet_askcall (hotkey is not used by inspect)_build_coldkey_table,_build_hotkey_table,_make_delegate_rows,_make_neuron_rows,_resolve_delegate_name,_calculate_daily_return,_format_hotkey_label,_populate_coldkey_table,_populate_hotkey_tableitertoolsimportFixes #233
Testing
pytest tests/unit_tests/-- 81 passed)ruff format .(v0.11.5)ruff check .on changed files