[tests] Added multi-tentant tests for shared objects

[pandafy]

Checklist

• I have read the OpenWISP Contributing Guidelines.
• I have manually tested the changes proposed in this pull request.
• I have written new test cases for new code and/or updated existing tests for changes to existing code.
• I have updated the documentation.

Blockers

• [feature] Allowed read only access of shared objects to non-superusers #238 openwisp-users#444

[pandafy]

TODO: Remove before merging

[nemesifier]

I tried accessing shared objects via REST API and this is what I found:

• Ok:
  • Device, Vpn, Credential, IPAM subnet
• Not ok:
  • Template: 403
  • Ca: 403
  • Cert: 403
  • Ip address list of a shared subnet, I get 404, eg: /api/v1/ipam/subnet/{pkl}/ip-address/

When using the admin it becomes evident that we'll need to work on #848 next.

[pandafy]

Upgrading openwisp-users was installing the latest version of cryptography which is incompatible with django-x509. Thus, pinning the dependency here fixed the CI build.

[coveralls]

coverage: 98.793% (+0.05%) from 98.746%
when pulling 8c9efc8 on updated-multitenant-tests
into 4ea68be on master.

[nemesifier]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Warning

Rate limit exceeded

@nemesifier has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 28 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1ee8c25 and 8c9efc8.

📒 Files selected for processing (16)

• .github/workflows/ci.yml
• openwisp_controller/config/migrations/0061_update_groups_permissions.py
• openwisp_controller/config/migrations/__init__.py
• openwisp_controller/config/tests/test_admin.py
• openwisp_controller/config/tests/test_api.py
• openwisp_controller/connection/base/models.py
• openwisp_controller/connection/tests/test_admin.py
• openwisp_controller/connection/tests/test_api.py
• openwisp_controller/geo/migrations/0004_update_groups_permissions.py
• openwisp_controller/geo/migrations/__init__.py
• openwisp_controller/pki/api/serializers.py
• openwisp_controller/pki/base/models.py
• openwisp_controller/pki/migrations/0012_update_group_permissions.py
• openwisp_controller/pki/migrations/__init__.py
• openwisp_controller/pki/tests/test_admin.py
• openwisp_controller/pki/tests/test_api.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}