Skip to content

refactor: remove now unneeded NameSetter interface #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
metacosm wants to merge 94 commits into from
Closed

refactor: remove now unneeded NameSetter interface #2578

metacosm wants to merge 94 commits into from

Conversation

@metacosm
Copy link
Collaborator

@metacosm metacosm commented Nov 15, 2024

Signed-off-by: Chris Laprun claprun@redhat.com

csviri and others added 30 commits November 13, 2024 20:02
@csviri
chore: set version to 5.0.0-SNAPSHOT (#2200)
611d174 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: java version minimal 11, tested on 21 (#2207)
d2e0098 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: remove deprecated EventFilter (#2208)
f8d3053 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
docs: 5.0 migration guide skeleton (#2210)
2a8dbe7 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: managed dependent reconciliation results not optional (#2212)
20cd096 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: remove deprecated RetryConfiguration (#2211)
9d680a4 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: JDK client is now the default (#2235)
8da2c88 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
fix: update SCM information (#2237)
0aad525 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: move name is directly to dependent resource (#2250)
27e9376 
* feat: move name is directly to dependent resource

- use this name when throwing aggregate exception

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* refactor to use a dedicated interface for setting the name

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* refactor: add default implementation for name() (#2255)

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
format
ad74901 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix: test after rebase on master (#2270)
1aa3bf5 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: use java 17 as baseline (#2271)
8744ab2 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: matcher always considers metadata (#2273)
37c6867 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: API to check if next reconciliation is imminent (#2272)
7927fc3 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: Workflow extracted to a separate annotation (#2274)
7a24651 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix: pom properties cleanup (#2280)
8e799e2 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
improve: remove EventSourceInitializer (#2257)
f3ade92 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: make loadFromProperties private (#2287)
18cf3a5 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: distinguish resources based on desired state (#2252)
4fb5552 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: explicit workflow invocation (#2289)
00a433f 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
feat: use ssa for status update by default from UpdateControl (#2278)
9fba9fe 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
refactor: make WorkflowSpec an interface (#2300)
98c02ce 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: replace current formatting plugins with spotless plugin (#2302)
e58c7dd 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: make ManagedWorkflowSupport public to be able to reuse it (#…
2899ae0 
…2308)

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix: package fix leader election sample (#2303)
4347e8f 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: remove resource discriminator (#2299)
f236acc 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: remove deprecated getTerminationTimeoutSeconds and associat…
2bd34de 
…ed (#2297)

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: additional logging to mysql schema e2e test (#2320)
26e9d84 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
ab49b79 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: using SSA for finalizer and primary patch (#2305)
bf7e58e 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri and others added 18 commits November 13, 2024 20:06
@csviri
improve: cleaner throws Exception (#2527)
585e412 

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@metacosm @csviri
feat: explicit node configuration in WorkflowBuilder (#2511)
f2311b5 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <claprun@redhat.com>

---------

Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
fix: cleanup after rebase on main
2b82f81 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
feat: context getSecondary resource is activation condition aware (#2532
76163c8 
)


Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
feat: e2e test to demonstrate namespace deletion problem fix (#2528)
c18de80 

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
docs: remove javadoc todos (#2541)
69e729d 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@10000-ki @csviri
feat: print diff resource as yaml (#2542)
b0522ff
@csviri
fix: integration test timeout issue (#2547)
a374796 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
improve: naming target resource selector method (#2546)
46ae8a2
@bachmanity1 @csviri
feat: improve diff logging (#2544)
a9b977f 
* imporve diff logging

Signed-off-by: bachmanity1 <bachmanity138@gmail.com>

* compute diff only when actual doesn't match desired

Signed-off-by: bachmanity1 <bachmanity138@gmail.com>

* slight improvements

Signed-off-by: bachmanity1 <bachmanity138@gmail.com>

* increase context size

Signed-off-by: bachmanity1 <bachmanity138@gmail.com>

* fix style

Signed-off-by: bachmanity1 <bachmanity138@gmail.com>

* calculate diff only if debug is enabled

Signed-off-by: bachmanity1 <bachmanity138@gmail.com>

* print actual resources when trace is enabled

Signed-off-by: bachmanity1 <bachmanity138@gmail.com>

* use java-diff-utils

Signed-off-by: bachmanity1 <bachmanity138@gmail.com>

* add unit tests

---------

Signed-off-by: bachmanity1 <bachmanity138@gmail.com>
@metacosm @csviri
fix: race condition in workflow reconciler (#2549)
7a7cffd 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
feat(ci): split integration tests execution by category (#2548)
a0b10e6 
* feat(build): split ITs by category, parallel CRD generation

Also avoid generating CRDs when not needed by default, summarizes test
results.

* chore(deps): bump actions-setup-minikube to 2.13.0
* feat: default to use vertx client
* chore(ci): reduce tested combinations, only run client tests on baseapi
* fix: increase deletion timeout

---------

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
refactor: rename method more appropriately (#2554)
f2ccea9 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
improve: workflow builder naming (#2559)
85c7cb2
@metacosm @csviri
chore: adapt after rebase
7dce326 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@Donnerbart @csviri
fix: infinite resource updates due to canonical format conversion of …
5f71aaa 
…resource requirements (#2565)

* refactor: clean up SSABasedGenericKubernetesResourceMatcher

Signed-off-by: David Sondermann <david.sondermann@hivemq.com>

* test: add missing tests for StatefulSet with VolumeClaimTemplates for SSABasedGenericKubernetesResourceMatcher

Signed-off-by: David Sondermann <david.sondermann@hivemq.com>

* fix: Fix infinite resource updates due to canonical format conversion of resource requirements

Signed-off-by: David Sondermann <david.sondermann@hivemq.com>

* test: Add test cases with init containers to ResourceRequirementsSanitizerTest

Signed-off-by: David Sondermann <david.sondermann@hivemq.com>

---------

Signed-off-by: David Sondermann <david.sondermann@hivemq.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
fix: concurrent modification when getting event sources (v5) (#2572)
6157e2b
@csviri
fix: issue after rebase
45759ff 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@metacosm metacosm self-assigned this Nov 15, 2024
@metacosm metacosm requested review from csviri and xstefank November 15, 2024 09:46
@openshift-ci openshift-ci bot requested a review from adam-sandor November 15, 2024 09:46
@csviri csviri force-pushed the remove-name-setter branch from 78b73ee to 320be81 Compare November 16, 2024 02:24
@metacosm
Copy link
Collaborator Author

metacosm commented Nov 19, 2024

This change actually cannot work without requiring a constructor taking the name as parameter for all DependentResource implementations.

@metacosm metacosm closed this Nov 19, 2024
@metacosm metacosm deleted the remove-name-setter branch November 19, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xstefank xstefank xstefank approved these changes

@csviri csviri Awaiting requested review from csviri

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees

@metacosm metacosm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@metacosm @xstefank @csviri @10000-ki @matteriben @bachmanity1 @Donnerbart