Conversation
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
added
needs-rebase
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
simplified the javadoc Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Chris Laprun <metacosm@gmail.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
- Adds utility that provides methods to update resources using comparable resource versions - Integrates this utility to the core of the framework (thus simplifying `ReconciliationDispatcher`) - note that this introduces a change in the behavior for the `UpdateControl.patchStatus` (and others), since it won't trigger the reconiliation for the event in that update. - Renames former `ReconcilerUtils` to `ReconcilerUtilsInternal`, this is breaking but that utils was never advertised for non-internal usage - Includes also fixes for ControllerEventSource event filtering - Improves TemporaryResourceCache event filtering algorithm Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Steve Hawkins <shawkins@redhat.com> Co-authored-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
This should not be user facing. At least not in any obvious scenerio. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
…om Context (#3142) Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@gmail.com>
#3146) Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
* refactor: avoid creating intermediate collections when unneeded Also use constant filters and collectors Signed-off-by: Chris Laprun <metacosm@gmail.com> * fix: incorrect test Signed-off-by: Chris Laprun <metacosm@gmail.com> --------- Signed-off-by: Chris Laprun <metacosm@gmail.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
openshift-merge-robot
removed
the
needs-rebase
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request bumps the version from 5.2.4-SNAPSHOT to 5.3.0-SNAPSHOT and introduces significant architectural improvements to event filtering and resource caching mechanisms. The changes include renaming the JUnit module, refactoring internal utility classes, and implementing a new event filtering approach based on comparable resource versions.
Changes:
- Version bump across all modules from 5.2.4-SNAPSHOT to 5.3.0-SNAPSHOT
- Renamed
operator-framework-junit-5module tooperator-framework-junit - Refactored
ReconcilerUtilstoReconcilerUtilsInternaland deprecated old utility methods - Implemented new event filtering mechanism using comparable resource versions
- Added
ResourceOperationsAPI for simplified resource manipulation - Introduced deduplication support for secondary resources in
Context
Reviewed changes
Copilot reviewed 129 out of 141 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml files | Version bump to 5.3.0-SNAPSHOT across all modules |
| operator-framework-junit/ | Module rename and new test infrastructure classes |
| ReconcilerUtilsInternal.java | Renamed from ReconcilerUtils with new resource version comparison methods |
| TemporaryResourceCache.java | Complete rewrite of event filtering logic using resource version comparison |
| Context.java | Added deduplication support and ResourceOperations |
| sample-operators/webpage/ | Updated to use new APIs with critical bugs introduced |
| Various test files | Updated expectations and added new test scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...le-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageReconciler.java
Outdated
Show resolved
Hide resolved
| // wait until both informers see the config map | ||
| return UpdateControl.noUpdate(); | ||
| } | ||
| // makes sure that distinc config maps returned |
There was a problem hiding this comment.
There's a typo in the comment - "distinc" should be "distinct".
...le-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageReconciler.java
Outdated
Show resolved
Hide resolved
[skip ci] Signed-off-by: Chris Laprun <metacosm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.