-
Notifications
You must be signed in to change notification settings - Fork 70
✨ Generate and use ApplyConfiguration types for Server-Side Apply #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,8 @@ limitations under the License. | |
| // Package v1 contains API Schema definitions for the olm v1 API group | ||
| // +kubebuilder:object:generate=true | ||
| // +groupName=olm.operatorframework.io | ||
| // +kubebuilder:ac:generate=true | ||
| // +kubebuilder:ac:output:package=../../applyconfigurations | ||
| package v1 | ||
|
|
||
| import ( | ||
|
|
@@ -28,6 +30,10 @@ var ( | |
| // GroupVersion is group version used to register these objects | ||
| GroupVersion = schema.GroupVersion{Group: "olm.operatorframework.io", Version: "v1"} | ||
|
|
||
| // SchemeGroupVersion is an alias for GroupVersion, required by the | ||
| // generated apply configuration code. | ||
| SchemeGroupVersion = GroupVersion | ||
|
Comment on lines
31
to
+35
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Assumed to be constant. If something changes it, I'd consider it a bug.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shame golang won't let you declare them as a constant. |
||
|
|
||
| // SchemeBuilder is used to add go types to the GroupVersionKind scheme | ||
| SchemeBuilder = &scheme.Builder{GroupVersion: GroupVersion} | ||
|
|
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joelanford should all APIs that we have use applyconfigurations now?
OR just the specific one?