🌱 MON-4516: Use endpointslices for metrics#2516
🌱 MON-4516: Use endpointslices for metrics#2516openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
Conversation
* Add permissions on endpointslice to Prometheus Role * Use serviceDiscoveryRole: EndpointSlice in ServiceMonitors Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR configures the OpenShift monitoring ServiceMonitor to use EndpointSlices for service discovery instead of the older Endpoints API. This aligns with Kubernetes' recommended approach for service discovery, as EndpointSlices provide better scalability and performance for large clusters.
Changes:
- Added
serviceDiscoveryRole: EndpointSliceto the olmv1 ServiceMonitor resource - Added RBAC permissions for
discovery.k8s.io/endpointslicesto the metrics monitor role
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| helm/olmv1/templates/servicemonitor-olmv1-system-metrics-monitor.yml | Added serviceDiscoveryRole field to enable EndpointSlice-based service discovery |
| helm/olmv1/templates/rbac/role-olmv1-system-metrics-monitor-role.yml | Added required RBAC permissions for accessing endpointslices resources |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2516 +/- ##
==========================================
- Coverage 73.21% 69.45% -3.77%
==========================================
Files 102 102
Lines 8505 8505
==========================================
- Hits 6227 5907 -320
- Misses 1802 2129 +327
+ Partials 476 469 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oceanc80, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override codecov/project |
|
@tmshort: Overrode contexts on behalf of tmshort: codecov/project DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 1ef820f
into
operator-framework:main
3 participants
Description
Reviewer Checklist