Make VFS locking APIs explicit by removing default lock/unlock implementations#70
Merged
carlsverre merged 2 commits intomainfrom Feb 20, 2026
Merged
Conversation
Co-authored-by: carlsverre <82591+carlsverre@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make locking VFS methods mandatory for improved safety
Make VFS locking APIs explicit by removing default lock/unlock implementations
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes implicit locking behavior from the
Vfstrait to reduce accidental misuse.lock,unlock, andcheck_reserved_lockare now required trait methods, marking an intentional breaking change for the next major/minor incompatible release (0.7.0).Trait API (breaking)
Vfs::lockVfs::unlockVfs::check_reserved_lockInternal/example implementers updated
MockVfstest implementation to provide the required methods.examples/memvfs.rsto implementcheck_reserved_lockin addition to existing lock/unlock methods.Changelog
0.7.0 (unreleased)entry documenting the incompatible API change and what downstream implementers must do.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.