Skip to content

[FEATURE REQUEST] Edit a space member #4774

Merged
joragua merged 12 commits intomasterfrom
feature/edit_a_space_member
Feb 18, 2026
Merged

[FEATURE REQUEST] Edit a space member #4774
joragua merged 12 commits intomasterfrom
feature/edit_a_space_member

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Feb 11, 2026

Related Issues

App: #4724

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.8/Spaces%20-%20Edit%20member.md

Reports:

@joragua joragua self-assigned this Feb 11, 2026
@joragua joragua linked an issue Feb 11, 2026 that may be closed by this pull request
12 tasks
@joragua joragua force-pushed the feature/edit_a_space_member branch 5 times, most recently from 77245dd to 532b2f0 Compare February 17, 2026 11:23
@joragua joragua marked this pull request as ready for review February 17, 2026 11:34
@joragua joragua requested a review from jesmrec February 17, 2026 11:34
@joragua joragua force-pushed the feature/edit_a_space_member branch from 7887679 to a5dade0 Compare February 17, 2026 11:48
android:src="@drawable/ic_lead_pencil_grey"
android:visibility="gone"
tools:visibility="visible" />

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no content description. Would it be required for a better accessibility?

Copy link
Collaborator Author

@joragua joragua Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contentDescription is set dynamically in the SpaceMembersAdapter. So, if you click the pencil button with Talkback enabled, it will read Edit member <name>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check in QA phase, then.

@joragua joragua requested a review from jesmrec February 17, 2026 13:42
Copy link
Collaborator

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 . Moving to QA

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 17, 2026

(1)

  1. Click on the pencil icon over a space member with expiration date
  2. Click on the expiration date in order to edit it
  3. In the date picker, click on Cancel

Current:

Expiration date is gone

Expected:

Expiration date with no changes, because the date picker was cancelled

Xiaomi Redmi Note 13
Android 15
118350d6

@joragua joragua force-pushed the feature/edit_a_space_member branch from ae906d5 to 65460c4 Compare February 17, 2026 16:13
@joragua
Copy link
Collaborator Author

joragua commented Feb 17, 2026

(1) should be fixed with the commit 65460c4

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 18, 2026

(2) (improvement) [DONE]

  1. Set an expiration date for any member
  2. Edit that member and click on expiration date

Current:

date picker is open, but the selected date is today

Expected:

opening the date picker and the default date is the existing expiration date.

Xiaomi Redmi Note 13, Galaxy Tab A8
Android 15
ae906d5fb

@joragua joragua force-pushed the feature/edit_a_space_member branch from 7aa0c7a to 5abfbc3 Compare February 18, 2026 10:25
@joragua
Copy link
Collaborator Author

joragua commented Feb 18, 2026

(2) should be done with the commit 5abfbc3 🙌🏻

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 18, 2026

Approved!!! 💯

@joragua joragua force-pushed the feature/edit_a_space_member branch from 5abfbc3 to 9227cd2 Compare February 18, 2026 12:01
@joragua joragua merged commit 4ac7b28 into master Feb 18, 2026
11 checks passed
@joragua joragua deleted the feature/edit_a_space_member branch February 18, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Edit a space member

3 participants

Comments