[FEATURE REQUEST] Edit a space member #4774
Conversation
77245dd to
532b2f0
Compare
7887679 to
a5dade0
Compare
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/AddMemberFragment.kt
Outdated
Show resolved
Hide resolved
...udApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersDiffUtil.kt
Outdated
Show resolved
Hide resolved
| android:src="@drawable/ic_lead_pencil_grey" | ||
| android:visibility="gone" | ||
| tools:visibility="visible" /> | ||
|
|
There was a problem hiding this comment.
There is no content description. Would it be required for a better accessibility?
There was a problem hiding this comment.
The contentDescription is set dynamically in the SpaceMembersAdapter. So, if you click the pencil button with Talkback enabled, it will read Edit member <name>
There was a problem hiding this comment.
Will check in QA phase, then.
(1)
Current: Expiration date is gone Expected: Expiration date with no changes, because the date picker was cancelled Xiaomi Redmi Note 13 |
ae906d5 to
65460c4
Compare
|
(1) should be fixed with the commit 65460c4 |
(2) (improvement) [DONE]
Current: date picker is open, but the selected date is today Expected: opening the date picker and the default date is the existing expiration date. Xiaomi Redmi Note 13, Galaxy Tab A8 |
7aa0c7a to
5abfbc3
Compare
|
(2) should be done with the commit 5abfbc3 🙌🏻 |
|
Approved!!! 💯 |
5abfbc3 to
9227cd2
Compare
Related Issues
App: #4724
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.8/Spaces%20-%20Edit%20member.md
Reports: