Skip to content

[FEATURE REQUEST] Copy permanent link of a space #4778

Merged
joragua merged 6 commits intomasterfrom
feature/copy_permanent_link_of_a_space
Feb 19, 2026
Merged

[FEATURE REQUEST] Copy permanent link of a space #4778
joragua merged 6 commits intomasterfrom
feature/copy_permanent_link_of_a_space

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Feb 18, 2026

Related Issues

App: #4758

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Feb 18, 2026
@joragua joragua linked an issue Feb 18, 2026 that may be closed by this pull request
10 tasks
@joragua joragua force-pushed the feature/copy_permanent_link_of_a_space branch 4 times, most recently from 44528dd to ab3cb7d Compare February 19, 2026 11:03
@joragua joragua marked this pull request as ready for review February 19, 2026 11:18
@joragua joragua requested a review from jesmrec February 19, 2026 11:19
@jesmrec jesmrec self-requested a review February 19, 2026 11:48
@joragua joragua force-pushed the feature/copy_permanent_link_of_a_space branch from 3c408eb to 7f8e783 Compare February 19, 2026 11:56
Copy link
Collaborator

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Moving to QA

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 19, 2026

QA checks:

  • Check visibility of the new icon (both orientations)
  • Check it is visible in every space, no matter the user's role
  • Compare the link shared with the space link
  • Check it is correctly shared
  • Accessibility

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 19, 2026

(1)

If the space has a long name, it collides with the chain icon:

Screenshot 2026-02-19 at 12 51 10

if the name is long, it should be ellipsized with ... as long names in other places. (other ideas welcome)

Xiaomi Redmi 13 Note, Android 15
3c408ebf5

@joragua
Copy link
Collaborator Author

joragua commented Feb 19, 2026

(1) should be fixed with the commit e07d5da

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 19, 2026

(1) fixed

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 19, 2026

Approved on my side!! 🚀

@joragua joragua force-pushed the feature/copy_permanent_link_of_a_space branch from e07d5da to b6c84a7 Compare February 19, 2026 13:59
@joragua joragua merged commit 5fbbcd6 into master Feb 19, 2026
11 checks passed
@joragua joragua deleted the feature/copy_permanent_link_of_a_space branch February 19, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Copy permanent link of a space

3 participants

Comments