fix: file size in cache is set back to zero if empty content is writt… by DeepDiver1975 · Pull Request #39016 · owncloud/core

DeepDiver1975 · 2021-07-16T10:45:12Z

…en to a non-empty file

Description

When writing zero length content to a non-empty file the file size in the file cache was not updated.

How Has This Been Tested?

see provided test

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

update-docs · 2021-07-16T10:45:16Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

phil-davis · 2021-07-16T10:56:54Z

https://drone.owncloud.com/owncloud/core/31293/2/7
make test-php-style fails.

phil-davis · 2021-07-16T12:22:56Z

Only the PHP unit tests on Oracle failed:
https://drone.owncloud.com/owncloud/core/31304/19/9

There were 1508 errors:

1) Test\Cache\FileCacheTest::testGarbageCollectOldKeys
Doctrine\DBAL\Exception\DriverException: An exception occurred while executing 'UPDATE "oc_filecache" SET "mtime" = NULL, "storage_mtime" = NULL WHERE ("mtime" IS NOT NULL OR "storage_mtime" IS NOT NULL) AND "fileid" = ?' with params [4]:

ORA-01407: cannot update ("AUTOTEST"."oc_filecache"."mtime") to NULL

/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractOracleDriver.php:69
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:182
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:159
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:2212
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1302
/drone/src/lib/private/DB/Connection.php:191
/drone/src/lib/private/Files/Cache/Cache.php:388
/drone/src/lib/private/Files/Cache/Updater.php:247
/drone/src/lib/private/Files/Cache/Updater.php:160
/drone/src/lib/private/Files/View.php:342
/drone/src/lib/private/Files/View.php:1239
/drone/src/lib/private/Files/View.php:776
/drone/src/lib/public/Events/EventEmitterTrait.php:50
/drone/src/lib/private/Files/View.php:786
/drone/src/lib/private/Cache/File.php:160
/drone/src/tests/lib/Cache/TestCache.php:19
/drone/src/tests/lib/Cache/FileCacheTest.php:91

Caused by
Doctrine\DBAL\Driver\OCI8\OCI8Exception: ORA-01407: cannot update ("AUTOTEST"."oc_filecache"."mtime") to NULL

/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Exception.php:25
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php:409
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1290
/drone/src/lib/private/DB/Connection.php:191
/drone/src/lib/private/Files/Cache/Cache.php:388
/drone/src/lib/private/Files/Cache/Updater.php:247
/drone/src/lib/private/Files/Cache/Updater.php:160
/drone/src/lib/private/Files/View.php:342
/drone/src/lib/private/Files/View.php:1239
/drone/src/lib/private/Files/View.php:776
/drone/src/lib/public/Events/EventEmitterTrait.php:50
/drone/src/lib/private/Files/View.php:786
/drone/src/lib/private/Cache/File.php:160
/drone/src/tests/lib/Cache/TestCache.php:19
/drone/src/tests/lib/Cache/FileCacheTest.php:91

2) Test\Cache\FileCacheTest::testGarbageCollectLeaveRecentKeys
Exception: Missing tearDown call in Test\Cache\FileCacheTest

/drone/src/tests/lib/Traits/UserTrait.php:52
/drone/src/tests/lib/TestCase.php:127
/drone/src/tests/lib/Cache/FileCacheTest.php:55

3) Test\Cache\FileCacheTest::testGarbageCollectIgnoreLockedKeys with data set #0 (OCP\Lock\LockedException Object (...))
Exception: Missing tearDown call in Test\Cache\FileCacheTest

/drone/src/tests/lib/Traits/UserTrait.php:52
/drone/src/tests/lib/TestCase.php:127
/drone/src/tests/lib/Cache/FileCacheTest.php:55
...

The first fail might be real?

But then it complains many times about Exception: Missing tearDown call in Test\Cache\FileCacheTest

I restarted CI so we can see if the fail is "variable".

phil-davis · 2021-07-16T12:25:07Z

@DeepDiver1975 I used current master and tried overwriting a file with an empty file, then downloading it. The download comes back empty, which is correct. So this problem does not seem to have an externally-observable bad behavior.

Is that correct? This just fixes an internal cache problem?

DeepDiver1975 · 2021-07-16T12:51:09Z

This just fixes and internal cache problem?

This is a pure PHP API fix from my understanding - it was discovered while working on some other app which used these functions that way ....

ownclouders · 2021-07-22T14:19:36Z

💥 Acceptance tests pipeline apiFederationToRoot1-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31469/107/1

sonarqubecloud · 2021-07-26T09:29:34Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

phil-davis · 2021-07-26T09:54:11Z

https://drone.owncloud.com/owncloud/core/31515/36/9
"something happened" (tm) in unit tests with Oracle.

DeepDiver1975 · 2021-07-26T10:52:12Z

https://drone.owncloud.com/owncloud/core/31515/36/9
"something happened" (tm) in unit tests with Oracle.

🤷

DeepDiver1975 · 2021-07-26T11:04:03Z

DeepDiver1975 · 2021-07-26T11:07:23Z

looks like I need to fire up oracle locally one more time ....

ownclouders · 2021-09-15T09:43:43Z

💥 Acceptance tests pipeline webUISharingPublic1-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32396/144/1

sonarqubecloud · 2021-09-15T10:28:36Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

50.0% Coverage
0.0% Duplication

butonic · 2022-07-26T10:08:03Z

@DeepDiver1975 merga master or rebase to kick ci again?

…en to a non-empty file

DeepDiver1975 · 2023-11-08T13:05:13Z

🙈

There were 5 failures:

1) Test\Files\Cache\UpdaterTest::testMove
Failed asserting that 0 matches expected 1699446390.

/drone/src/tests/lib/Files/Cache/UpdaterTest.php:147
phpvfscomposer:///drone/src/lib/composer/phpunit/phpunit/phpunit:106

2) Test\Files\Cache\UpdaterTest::testMoveNonExistingOverwrite
Failed asserting that 0 matches expected 1699446390.

/drone/src/tests/lib/Files/Cache/UpdaterTest.php:165
phpvfscomposer:///drone/src/lib/composer/phpunit/phpunit/phpunit:106

3) Test\Files\Cache\UpdaterTest::testUpdateStorageMTime
file mtime preserved
Failed asserting that 0 matches expected 1699446390.

/drone/src/tests/lib/Files/Cache/UpdaterTest.php:200
phpvfscomposer:///drone/src/lib/composer/phpunit/phpunit/phpunit:106

4) Test\Files\Cache\UpdaterTest::testMoveCrossStorage
Failed asserting that 0 matches expected 1699446390.

/drone/src/tests/lib/Files/Cache/UpdaterTest.php:246
phpvfscomposer:///drone/src/lib/composer/phpunit/phpunit/phpunit:106

5) Test\Files\Cache\UpdaterTest::testMoveFolderCrossStorage
Failed asserting that 0 matches expected 1699446390.

/drone/src/tests/lib/Files/Cache/UpdaterTest.php:300
phpvfscomposer:///drone/src/lib/composer/phpunit/phpunit/phpunit:106

DeepDiver1975 self-assigned this Jul 16, 2021

DeepDiver1975 force-pushed the fix/update-cache-size-when-emptying-a-file branch from 7634ce8 to 53196ce Compare July 16, 2021 10:47

DeepDiver1975 force-pushed the fix/update-cache-size-when-emptying-a-file branch from 53196ce to aeca425 Compare July 16, 2021 11:19

jvillafanez approved these changes Jul 16, 2021

View reviewed changes

AlexAndBear self-requested a review July 19, 2021 08:04

AlexAndBear approved these changes Jul 19, 2021

View reviewed changes

DeepDiver1975 force-pushed the fix/update-cache-size-when-emptying-a-file branch from aeca425 to 99801e4 Compare July 26, 2021 09:00

DeepDiver1975 force-pushed the fix/update-cache-size-when-emptying-a-file branch from 99801e4 to 5fb41b0 Compare September 15, 2021 08:30

DeepDiver1975 force-pushed the fix/update-cache-size-when-emptying-a-file branch from 5d74544 to d293089 Compare September 15, 2021 09:59

DeepDiver1975 added 2 commits November 8, 2023 12:58

fix: file size in cache is set back to zero if empty content is writt…

f4de277

…en to a non-empty file

fix: use mtime 0 instead of NULL - Oracel fix

a269c4a

DeepDiver1975 force-pushed the fix/update-cache-size-when-emptying-a-file branch from d293089 to a269c4a Compare November 8, 2023 11:59

Conversation

DeepDiver1975 commented Jul 16, 2021

Description

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

update-docs bot commented Jul 16, 2021

Uh oh!

phil-davis commented Jul 16, 2021

Uh oh!

phil-davis commented Jul 16, 2021

Uh oh!

phil-davis commented Jul 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DeepDiver1975 commented Jul 16, 2021

Uh oh!

ownclouders commented Jul 22, 2021

Uh oh!

sonarqubecloud bot commented Jul 26, 2021

Uh oh!

phil-davis commented Jul 26, 2021

Uh oh!

DeepDiver1975 commented Jul 26, 2021

Uh oh!

DeepDiver1975 commented Jul 26, 2021

Uh oh!

DeepDiver1975 commented Jul 26, 2021

Uh oh!

ownclouders commented Sep 15, 2021

Uh oh!

sonarqubecloud bot commented Sep 15, 2021

Uh oh!

butonic commented Jul 26, 2022

Uh oh!

DeepDiver1975 commented Nov 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

phil-davis commented Jul 16, 2021 •

edited

Loading