-
Notifications
You must be signed in to change notification settings - Fork 8
Fix Dependabot azure-monitor-opentelemetry-exporter upgrade with compatible dependencies #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ble dependencies Co-authored-by: pamelafox <297042+pamelafox@users.noreply.github.com>
Co-authored-by: pamelafox <297042+pamelafox@users.noreply.github.com>
.gitignore
Outdated
| # Environments | ||
| .env | ||
| .venv | ||
| .venv2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line, .venv2 is not a usual Python venv name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the .venv2 line from .gitignore. You're right that it's not a standard Python virtual environment name. (5d11562)
|
@copilot This PR no longer does an actual upgrade |
Co-authored-by: pamelafox <297042+pamelafox@users.noreply.github.com>
This PR does perform the actual upgrade. The requirements.txt file shows: Before: And also upgraded the compatible dependency: The upgrade was done in commit a9b02dd. Could you clarify what makes you think the upgrade isn't there? |
This PR resolves the CI failure in Dependabot PR #92 by upgrading
azure-monitor-opentelemetry-exporterfrom 1.0.0b26 to 1.0.0b29 along with compatible OpenTelemetry packages.Problem
The original Dependabot PR failed CI because upgrading
azure-monitor-opentelemetry-exporterto 1.0.0b29 created dependency compatibility issues with the existingopentelemetry-instrumentation-fastapi==0.46b0. This is a common pattern with OpenTelemetry packages where related components need to be updated together to maintain compatibility.Solution
azure-monitor-opentelemetry-exporterfrom 1.0.0b26 to 1.0.0b29 (the main goal)opentelemetry-instrumentation-fastapifrom 0.46b0 to 0.48b0 for compatibility[tool.ruff.lint]sectionBenefits
The azure-monitor-opentelemetry-exporter 1.0.0b29 release includes:
Verification
To verify the fix works:
python -m venv .venv source .venv/bin/activate python -m pip install --upgrade pip python -m pip install -r requirements-dev.txtAll code syntax validation, linting (ruff), and formatting (black) checks pass with these changes.
Fixes #100.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.