fix: correctly decrement remaining_deps for multiple skipped parents#606
Conversation
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
View your CI Pipeline Execution ↗ for commit 0b9906b
☁️ Nx Cloud last updated this comment at |
91df928 to
0b9906b
Compare
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-606.pgflow.pages.dev 📝 Details:
_Last updated: _ |

Fix remaining_deps decrement for multiple skipped parents
This PR fixes a bug where child steps with multiple skipped parent steps would not have their
remaining_depsdecremented correctly. Previously, when multiple parent steps were skipped simultaneously, the child'sremaining_depswould only be decremented by 1 regardless of how many parents were skipped.The fix:
skipped_parent_countsthat counts how many skipped parents each child step hasdependent_updatesquery to decrementremaining_depsby the actual count of skipped parentsmulti_parent_skip_decrements_remaining_deps.test.sql- Tests that when two parent steps are skipped, the child'sremaining_depsis decremented by 2multi_parent_skip_then_complete.test.sql- Tests a more complex scenario with three parents where two are skipped and one completes normallyThis ensures that workflows with conditional branches properly advance when multiple parent steps are skipped in the same cascade resolution.