Fix nested BBCode quote handling in BbcodeToDjot converter #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous regex-based approach using .*? (non-greedy) failed to properly match nested [quote] tags because it would match from an opening tag to the first closing tag, regardless of nesting. For example: [quote=A]outer[quote=B]inner[/quote][/quote] Would incorrectly match [quote=A]outer[quote=B]inner[/quote] leaving an orphan [/quote] tag. This fix replaces the regex approach with depth tracking that: - Tracks nesting depth as it encounters opening/closing tags - Properly matches each opening tag with its corresponding closing tag - Recursively processes nested quotes to convert them all Added 7 new test cases covering: - Basic nested quotes with authors - Deeply nested quotes (3 levels) - Nested quotes without authors - Text before/after quotes - Multiple quotes at same level - Complex quote attributes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
=========================================
Coverage 93.40% 93.40%
- Complexity 1928 1952 +24
=========================================
Files 74 74
Lines 5183 5233 +50
=========================================
+ Hits 4841 4888 +47
- Misses 342 345 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Remove redundant `$depth > 0` checks flagged by PHPStan - Use proper Djot caption syntax `^ Author` after blockquote instead of inline `*Author wrote:*` within the quote
Extract date/time attributes from BBCode quote values and format as "name (datetime)" in the caption. Handles: - [quote=user] -> ^ user - [quote=user date="2024-01-01"] -> ^ user (2024-01-01) - [quote=user date="2024-01-01" time="12:30"] -> ^ user (2024-01-01 12:30)
Handle BBCode quote formats like: - [quote="9" name="superadmin" date="2025-12-06 18:35:26"] - [quote id="42" name="admin" date="2024-01-01"] Output format: ^ name (datetime) #id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes nested
[quote]tag handling inBbcodeToDjotconverter and improves quote attribution formatting.Changes
1. Fix Nested Quotes
The previous regex-based approach failed on nested quotes because
.*?(non-greedy) matches to the first[/quote]regardless of nesting depth. Replaced with depth-tracking parser.2. Proper Djot Caption Syntax
Changed from inline
*Author wrote:*to proper Djot caption syntax (^ Author) which renders as<figcaption>.3. Parse Quote Attributes
Extract ID, name, date/time from various BBCode quote formats:
[quote=John]^ John[quote=John date="2024-01-01"]^ John (2024-01-01)[quote=John date="2024-01-01" time="12:30"]^ John (2024-01-01 12:30)[quote="9" name="admin" date="2024-01-01 12:30"]^ admin (2024-01-01 12:30) #9[quote id="42" name="user" date="2024-01-01"]^ user (2024-01-01) #424. PHPStan Fixes
Fixed redundant
$depth > 0comparisons.Test Plan