Fix GH-80: Trim whitespace in tag content before link resolution#237
Open
lacatoire wants to merge 3 commits intophp:masterfrom
Open
Fix GH-80: Trim whitespace in tag content before link resolution#237lacatoire wants to merge 3 commits intophp:masterfrom
lacatoire wants to merge 3 commits intophp:masterfrom
Conversation
When <function>, <methodname>, <classname>, <varname>, <type>, or <enumidentifier> tags contain leading/trailing whitespace (e.g. from line breaks in translated documentation), link resolution fails because the lookup key includes the whitespace. Add trim() to all text handler functions that resolve links, ensuring whitespace does not break cross-reference linking.
Girgias
reviewed
Feb 15, 2026
Co-authored-by: Gina Peter Banyard <girgias@php.net>
… fix varname CSS class - Add static Format::trimValue() that trims whitespace and emits E_USER_WARNING when whitespace is found in tag content - Replace all bare trim() calls with Format::trimValue() in PHP and PEAR XHTML formatters - Fix class="classname" to class="varname" in format_varname_text link - Update test expected output for warnings and CSS class fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trim()to all text handler functions that resolve links (format_function_text,format_varname_text,format_classname_text,format_type_text,format_enumidentifier_text, and classsynopsis variants) in both PHP and PEAR XHTML packages<function>,<methodname>,<classname>,<varname>,<type>, or<enumidentifier>tags contain leading/trailing whitespace (e.g. from line breaks in translated documentation), link resolution was failing because the lookup key included the whitespace<function>,<methodname>,<classname>, and<varname>tags with whitespaceFixes #80