Fix GH-20503: Assertion failure with ext/date DateInterval property hash construction #20720
+49
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y hash When a DateInterval object has a circular reference (e.g., $obj->prop = $obj), calling json_encode() triggered an assertion failure because the get_properties handler modified a HashTable with refcount > 1. Added a get_properties_for handler for DateInterval that duplicates the properties array before modification, matching the pattern used by DateTime and DateTimeZone.
heathdutton
force-pushed
the
fix-gh-20503
branch
from
3a6784b to
8fc8584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a DateInterval object has a circular reference (e.g.,
$obj->prop = $obj), callingjson_encode()triggers an assertion failure in debug builds. This happens because theget_propertieshandler tries to modify the properties HashTable in place, but circular references cause the HashTable to have a refcount > 1, which violates the assertion inzend_hash_str_update().This adds a
get_properties_forhandler for DateInterval that duplicates the properties array before adding the internal interval properties. This matches the existing pattern used by DateTime and DateTimeZone, which already have both handlers for the same reason.The original
get_propertieshandler is preserved for backward compatibility withget_object_vars().Fixes GH-20503