Skip to content

Improve performance of in_array #21105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorgsowa wants to merge 1 commit into
base: master
Choose a base branch
from
+103 −39
Open

Improve performance of in_array #21105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
142 changes: 103 additions & 39 deletions ext/standard/array.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1529,91 +1529,155 @@ PHP_FUNCTION(array_walk_recursive)
*/
static inline void _php_search_array(zval *return_value, zval *value, zval *array, bool strict, int behavior) /* {{{ */
{
zval *entry; /* pointer to array entry */
zval *entry;
zend_ulong num_idx;
zend_string *str_idx;

if (strict) {
if (Z_TYPE_P(value) == IS_LONG) {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
ZVAL_DEREF(entry);
if (Z_TYPE_P(entry) == IS_LONG && Z_LVAL_P(entry) == Z_LVAL_P(value)) {
if (behavior == 0) {
RETURN_TRUE;
} else {
if (behavior == 0) {
if (HT_IS_PACKED(Z_ARRVAL_P(array))) {
ZEND_HASH_PACKED_FOREACH_VAL(Z_ARRVAL_P(array), entry) {
ZVAL_DEREF(entry);
if (Z_TYPE_P(entry) == IS_LONG && Z_LVAL_P(entry) == Z_LVAL_P(value)) {
RETURN_TRUE;
}
} ZEND_HASH_FOREACH_END();
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry)
Copy link
Member

@iluuu1994 iluuu1994 Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can replace all of these with ZEND_HASH_MAP_FOREACH_KEY_VAL().

{
Copy link
Member

@iluuu1994 iluuu1994 Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Keep { on the same line.

ZVAL_DEREF(entry);
if (Z_TYPE_P(entry) == IS_LONG && Z_LVAL_P(entry) == Z_LVAL_P(value)) {
RETURN_TRUE;
}
} ZEND_HASH_FOREACH_END();
}
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
ZVAL_DEREF(entry);
if (Z_TYPE_P(entry) == IS_LONG && Z_LVAL_P(entry) == Z_LVAL_P(value)) {
if (str_idx) {
RETURN_STR_COPY(str_idx);
} else {
RETURN_LONG(num_idx);
}
}
}
} ZEND_HASH_FOREACH_END();
} ZEND_HASH_FOREACH_END();
}
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
ZVAL_DEREF(entry);
if (fast_is_identical_function(value, entry)) {
if (behavior == 0) {
RETURN_TRUE;
} else {
if (behavior == 0) {
if (HT_IS_PACKED(Z_ARRVAL_P(array))) {
ZEND_HASH_PACKED_FOREACH_VAL(Z_ARRVAL_P(array), entry) {
ZVAL_DEREF(entry);
if (fast_is_identical_function(value, entry)) {
RETURN_TRUE;
}
} ZEND_HASH_FOREACH_END();
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
ZVAL_DEREF(entry);
if (fast_is_identical_function(value, entry)) {
RETURN_TRUE;
}
} ZEND_HASH_FOREACH_END();
}
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
ZVAL_DEREF(entry);
if (fast_is_identical_function(value, entry)) {
if (str_idx) {
RETURN_STR_COPY(str_idx);
} else {
RETURN_LONG(num_idx);
}
}
}
} ZEND_HASH_FOREACH_END();
} ZEND_HASH_FOREACH_END();
}
}
} else {
if (Z_TYPE_P(value) == IS_LONG) {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
if (fast_equal_check_long(value, entry)) {
if (behavior == 0) {
RETURN_TRUE;
} else {
if (behavior == 0) {
if (HT_IS_PACKED(Z_ARRVAL_P(array))) {
ZEND_HASH_PACKED_FOREACH_VAL(Z_ARRVAL_P(array), entry) {
if (fast_equal_check_long(value, entry)) {
RETURN_TRUE;
}
} ZEND_HASH_FOREACH_END();
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
if (fast_equal_check_long(value, entry)) {
RETURN_TRUE;
}
} ZEND_HASH_FOREACH_END();
}
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
if (fast_equal_check_long(value, entry)) {
if (str_idx) {
RETURN_STR_COPY(str_idx);
} else {
RETURN_LONG(num_idx);
}
}
}
} ZEND_HASH_FOREACH_END();
} ZEND_HASH_FOREACH_END();
}
} else if (Z_TYPE_P(value) == IS_STRING) {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
if (fast_equal_check_string(value, entry)) {
if (behavior == 0) {
RETURN_TRUE;
} else {
if (behavior == 0) {
if (HT_IS_PACKED(Z_ARRVAL_P(array))) {
ZEND_HASH_PACKED_FOREACH_VAL(Z_ARRVAL_P(array), entry) {
if (fast_equal_check_string(value, entry)) {
RETURN_TRUE;
}
} ZEND_HASH_FOREACH_END();
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
if (fast_equal_check_string(value, entry)) {
RETURN_TRUE;
}
} ZEND_HASH_FOREACH_END();
}
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
if (fast_equal_check_string(value, entry)) {
if (str_idx) {
RETURN_STR_COPY(str_idx);
} else {
RETURN_LONG(num_idx);
}
}
}
} ZEND_HASH_FOREACH_END();
} ZEND_HASH_FOREACH_END();
}
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
if (fast_equal_check_function(value, entry)) {
if (behavior == 0) {
RETURN_TRUE;
} else {
if (behavior == 0) {
if (HT_IS_PACKED(Z_ARRVAL_P(array))) {
ZEND_HASH_PACKED_FOREACH_VAL(Z_ARRVAL_P(array), entry) {
if (fast_equal_check_function(value, entry)) {
RETURN_TRUE;
}
} ZEND_HASH_FOREACH_END();
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
if (fast_equal_check_function(value, entry)) {
RETURN_TRUE;
}
} ZEND_HASH_FOREACH_END();
}
} else {
ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_idx, str_idx, entry) {
if (fast_equal_check_function(value, entry)) {
if (str_idx) {
RETURN_STR_COPY(str_idx);
} else {
RETURN_LONG(num_idx);
}
}
}
} ZEND_HASH_FOREACH_END();
} ZEND_HASH_FOREACH_END();
}
}
}

RETURN_FALSE;
}
/* }}} */

/* void php_search_array(INTERNAL_FUNCTION_PARAMETERS, int behavior)
* 0 = return boolean
Expand Down
Loading