Zend: Remove unused parameter from zend_dval_to_lval_cap() #21112
+9
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Category: Engine
Extension: dom
Extension: tidy
ABI break
labels
iluuu1994
reviewed
Feb 2, 2026
Zend/zend_operators.c
Outdated
| */ | ||
| if (op_str == NULL) { | ||
| /* zend_dval_to_lval_cap() can emit a warning so always do the copy here */ | ||
| /* zend_incompatible_string_to_long_error() needs op_str, so always do the copy here */ |
Member
There was a problem hiding this comment.
I don't see how this applies any longer. The zend_string_copy could be moved just above zend_incompatible_string_to_long_error, and zend_string_release changed to zend_tmp_string_release.
The `zend_string *s` parameter became unused after commit f754ffa (phpGH-20746) removed the `zend_oob_string_to_long_error()` calls. This fixes an unused-parameter compiler warning and updates a stale comment in zend_operators.c that incorrectly stated this function can emit warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zend_string *sparameter became unused after commit f754ffa (GH-20746) removed thezend_oob_string_to_long_error()calls.This fixes an unused-parameter compiler warning and updates a stale comment in zend_operators.c that incorrectly stated this function can emit warnings.