Implement __set_state() for all AST node classes#284
Merged
ondrejmirtes merged 4 commits into2.3.xfrom Jan 12, 2026
Merged
Conversation
Add __set_state() magic method to all 68 AST node classes to enable var_export() serialization for caching purposes. Implementation details: - All classes now support reconstruction via var_export() - Constructor parameters are properly extracted from properties array - Attributes are restored after instance creation - Optional parameters handled with null coalescing operator Classes updated: - Type nodes: 20 classes (ArrayTypeNode, GenericTypeNode, etc.) - ConstExpr nodes: 10 classes (ConstExprArrayNode, ConstFetchNode, etc.) - PhpDoc core: 4 classes (PhpDocNode, PhpDocTagNode, etc.) - PhpDoc tag values: 29 classes (ParamTagValueNode, ReturnTagValueNode, etc.) - Doctrine nodes: 5 classes (DoctrineAnnotation, DoctrineArray, etc.) All tests pass (3711 tests, 19858 assertions) PHPStan analysis passes with no errors
ondrejmirtes
force-pushed
the
claude/caching-set-state-LKilR
branch
from
0f86d57 to
aac6fb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.