Conversation
biozshock
force-pushed
the
fix-13444
branch
from
023fb7b to
b7370a0
Compare
| 'Memcached::get' => ['hasSideEffects' => true], | ||
| 'Memcached::getByKey' => ['hasSideEffects' => true], | ||
| 'Memcached::getDelayed' => ['hasSideEffects' => true], | ||
| 'Memcached::getDelayedByKey' => ['hasSideEffects' => true], | ||
| 'Memcached::getMulti' => ['hasSideEffects' => true], | ||
| 'Memcached::getMultiByKey' => ['hasSideEffects' => true], | ||
| 'Memcached::getServerByKey' => ['hasSideEffects' => true], |
There was a problem hiding this comment.
Does get method has side effects too ?
There was a problem hiding this comment.
@VincentLanglet I'm sorry, which "get" method?
The getServerByKey, where your comment is located has the side effect: https://www.php.net/manual/en/memcached.getserverbykey.php#refsect1-memcached.getserverbykey-returnvalues
There was a problem hiding this comment.
I meant all the getFoo method sonce they arr just getter
But if I understand correctly they all have side effect because they have impact on the getResultCode
There was a problem hiding this comment.
@VincentLanglet exactly. I think that i've marked all methods that change getResultCode.
|
Might be better to wait for #4422 and use the same strategy |
Not all methods are impure, so that wouldn't work. |
|
@biozshock It might be still fewer lines of information to mark all as impure and the exclude a few with |
3 participants
Fixes phpstan/phpstan#13444