Skip to content

Mark RedisCluster method as impure#4415

Closed
VincentLanglet wants to merge 2 commits intophpstan:2.1.xfrom
VincentLanglet:rediscluster
Closed

Mark RedisCluster method as impure#4415
VincentLanglet wants to merge 2 commits intophpstan:2.1.xfrom
VincentLanglet:rediscluster

Conversation

@VincentLanglet
Copy link
Contributor

Similar to #4409

@ondrejmirtes
Copy link
Member

Would you want to add something like @phpstan-all-methods-impure and pure above classes? It'd be more maintainable than this.

It'd still be possible to exclude a method and do the opposite above it.

@VincentLanglet
Copy link
Contributor Author

Would you want to add something like @phpstan-all-methods-impure and pure above classes? It'd be more maintainable than this.

It'd still be possible to exclude a method and do the opposite above it.

Like this phpstan/phpdoc-parser#277 ?

@VincentLanglet
Copy link
Contributor Author

Closing in favor of #4422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants