Skip to content

Fix #14124: Reassigning to array<string, list<T>> out parameter does not see the list<T> property during assignment #4999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phpstan-bot wants to merge 1 commit into from
+36 −2
Closed

Fix #14124: Reassigning to array<string, list<T>> out parameter does not see the list<T> property during assignment #4999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Analyser/NodeScopeResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6297,7 +6297,7 @@ private function processAssignVar(

if ($varType->isArray()->yes() || !(new ObjectType(ArrayAccess::class))->isSuperTypeOf($varType)->yes()) {
if ($var instanceof Variable && is_string($var->name)) {
$this->callNodeCallback($nodeCallback, new VariableAssignNode($var, $assignedPropertyExpr), $scopeBeforeAssignEval, $storage);
$this->callNodeCallback($nodeCallback, new VariableAssignNode($var, new TypeExpr($valueToWrite)), $scopeBeforeAssignEval, $storage);
$scope = $scope->assignVariable($var->name, $valueToWrite, $nativeValueToWrite, TrinaryLogic::createYes());
} else {
if ($var instanceof PropertyFetch || $var instanceof StaticPropertyFetch) {
Expand All @@ -6314,7 +6314,7 @@ private function processAssignVar(
}
} else {
if ($var instanceof Variable) {
$this->callNodeCallback($nodeCallback, new VariableAssignNode($var, $assignedPropertyExpr), $scopeBeforeAssignEval, $storage);
$this->callNodeCallback($nodeCallback, new VariableAssignNode($var, new TypeExpr($valueToWrite)), $scopeBeforeAssignEval, $storage);
} elseif ($var instanceof PropertyFetch || $var instanceof StaticPropertyFetch) {
$this->callNodeCallback($nodeCallback, new PropertyAssignNode($var, $assignedPropertyExpr, $isAssignOp), $scopeBeforeAssignEval, $storage);
if ($var instanceof PropertyFetch && $var->name instanceof Node\Identifier && !$isAssignOp) {
Expand Down
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/Variables/ParameterOutAssignedTypeRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,9 @@ public function testBug12754(): void
$this->analyse([__DIR__ . '/data/bug-12754.php'], []);
}

public function testBug14124(): void
{
$this->analyse([__DIR__ . '/data/bug-14124.php'], []);
}

}
29 changes: 29 additions & 0 deletions tests/PHPStan/Rules/Variables/data/bug-14124.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?php

namespace Bug14124;

/**
* @param array<string, list<string>> $convert
* @param-out array<string, list<string>> $convert
*/
function example3a(array &$convert): void
{
foreach ($convert as &$inner) {
foreach ($inner as &$val) {
$val = strtoupper($val);
}
}
}

/**
* @param array<string, list<string>> $convert
* @param-out array<string, list<string>> $convert
*/
function example3b(array &$convert): void
{
foreach ($convert as $outerKey => $inner) {
foreach ($inner as $key => $val) {
$convert[$outerKey][$key] = strtoupper($val);
}
}
}
Loading