False Positive on Match Arm Comparison with Incremented Bounded Integer#5003
Open
VincentLanglet wants to merge 3 commits intophpstan:2.1.xfrom
Open
False Positive on Match Arm Comparison with Incremented Bounded Integer#5003VincentLanglet wants to merge 3 commits intophpstan:2.1.xfrom
VincentLanglet wants to merge 3 commits intophpstan:2.1.xfrom
Conversation
- MutatingScope::enterMatch() re-evaluated the condition type after the scope had already been updated by processing the increment expression, causing $i++ to be seen as int<1, max> instead of int<0, max> - Pass the pre-computed condition type and native type from NodeScopeResolver to enterMatch() so it uses the correct types - New regression test in tests/PHPStan/Rules/Comparison/data/bug-11310.php Closes phpstan/phpstan#11310
Automated fix attempt 1 for CI failures.
VincentLanglet
force-pushed
the
fix/11310
branch
from
11bfbfe to
535cebc
Compare
Collaborator
|
This pull request has been marked as ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired from #4968
Closes phpstan/phpstan#11310