Better management of Ebean Shutdown on SIGTERM

[AntoineDuComptoirDesPharmacies]

This pull request aims to fix the problem of Ebean Issue 3420 (ebean-orm/ebean#3420) where SIGTERM signal will immediately shutdown the ThreadPoolExecutor of Ebean, causing some reject on async count tasks while HTTP request is in progress.

This is solved by calling ShutdownManager.shutdown() on application lifecycle stopHook instead of closing each database individually.
Note that we have to call ShutdownManager.deregisterShutdownHook() to avoid Ebean triggering shutdown on SIGTERM signal.

[mkurz]

Can you please

1. Run sbt formatCode
2. Squash your changes into one single commit on top of main?

Thanks!

[AntoineDuComptoirDesPharmacies]

Can you please

1. Run sbt formatCode
2. Squash your changes into one single commit on top of main?

Thanks!

Done ! 👍

[mkurz]

Also can you please give the commit a better commit message instead of just # Ebean 3420? It's hard to tell what the commit does when just looking at the git log.

[AntoineDuComptoirDesPharmacies]

Also can you please give the commit a better commit message instead of just # Ebean 3420? It's hard to tell what the commit does when just looking at the git log.

Current commit message is :

# Ebean 3420
Create EbeanLifecycle component to manage Ebean shutdown

But I will try to add more line to explain the content. 👍

[mkurz]

Also can you please give the commit a better commit message instead of just # Ebean 3420? It's hard to tell what the commit does when just looking at the git log.

Current commit message is :

# Ebean 3420
Create EbeanLifecycle component to manage Ebean shutdown

But I will try to add more line to explain the content. 👍

No need to add more lines, just the first line should be more meaningful.

[AntoineDuComptoirDesPharmacies]

Commit message changed and comment taken into account. 👍

[mkurz]

Why do you actually not just replace this code with the code you added in EbeanLifecycle? Why do you even need the EbeanLifecycle class? Isn't it much more straigt forward to change this code here and thats it?

[AntoineDuComptoirDesPharmacies]

Hi @mkurz ,
It is clearly possible to change the code in-place.
The objective of adding it to a new class named EbeanLifecycle is about separation of concern between Ebean lifecycle and Evolution feature.

Do you want us to change the code in-place and delete EbeanLifecycle class ?