Skip to content

Adjust Chrome flags in CI to fix broken jobs #7700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 12 commits into from
Jan 30, 2026
+18 −4
Merged

Adjust Chrome flags in CI to fix broken jobs #7700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
97b36a7
pin chrome version in noCI tests to 146.0.7649.0
emilykl Jan 27, 2026
c41b4e9
use setup-chrome@v2
emilykl Jan 27, 2026
1a072b3
install chromedriver
emilykl Jan 27, 2026
0007298
set CHROME_BIN env var so that Chrome version installed by setup-chro…
emilykl Jan 27, 2026
4bca1d8
launch chrome with --no-sandbox in CI
emilykl Jan 28, 2026
88bc352
add --use-gl=desktop flag for Chrome in CI
emilykl Jan 28, 2026
2f947c4
different combination of Chrome flags
emilykl Jan 28, 2026
7656266
remove exact chrome version pin
emilykl Jan 28, 2026
6b00e45
use swiftshader ONLY for github actions tests
emilykl Jan 28, 2026
880f838
adjust conditional Chrome flags
emilykl Jan 29, 2026
7653cf0
Try simply --enable-unsafe-swiftshader flag instead
emilykl Jan 29, 2026
e22bfd2
update comment
emilykl Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,20 @@ jobs:
node-version: [18.x]

steps:
- uses: browser-actions/setup-chrome@v1
- uses: browser-actions/setup-chrome@v2
id: setup-chrome
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: chrome --version
- name: Set Chrome binary path
run: echo "CHROME_BIN=${{ steps.setup-chrome.outputs.chrome-path }}" >> $GITHUB_ENV
- name: Verify Chrome version
run: |
echo "Chrome path: $CHROME_BIN"
$CHROME_BIN --version
- run: ls
- run: npm run pretest
- run: npm ci
Expand Down
12 changes: 10 additions & 2 deletions test/jasmine/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,14 +253,22 @@ func.defaultConfig = {
//
// window-size values came from observing default size
//
// '--ignore-gpu-blacklist' allow to test WebGL on CI (!!!)
// '--ignore-gpu-blocklist' allow to test WebGL on CI (!!!)
Copy link
Contributor Author

@emilykl emilykl Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blacklist -> blocklist change is because Chrome renamed the flag

customLaunchers: {
_Chrome: {
base: 'Chrome',
flags: [
'--touch-events',
'--window-size=' + argv.width + ',' + argv.height,
isCI ? '--ignore-gpu-blacklist' : '',
isCI ? '--ignore-gpu-blocklist' : '',
// The following two flags are needed only for the "NoCI" tests which run in GitHub Actions.
// The first is needed because the GPU is not available to those runners,
// and therefore we need to use SwiftShader instead (which is disabled by default as of Jan 2026,
// hence the need for a flag to manually enable it).
// The second flag is needed because the Chrome browser installed by the CI job runner
// fails without it.
isCI && process.env.GITHUB_ACTIONS ? '--enable-unsafe-swiftshader' : '',
isCI && process.env.GITHUB_ACTIONS ? '--no-sandbox' : '',
isBundleTest && basename(testFileGlob) === 'no_webgl' ? '--disable-webgl' : ''
]
},
Expand Down